Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-07-13 Thread Paul Walmsley
On Tue, 12 Jul 2011, Pavel Machek wrote: On Wed 2011-06-29 18:40:23, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM at boot and after wake-up from CORE OFF mode. However only a

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-07-12 Thread Pavel Machek
On Wed 2011-06-29 18:40:23, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM at boot and after wake-up from CORE OFF mode. However only a small part of the code really needs to run from

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-30 Thread Peter De Schrijver
+/* + * This function implements the erratum ID i581 WA: + * SDRC state restore before accessing the SDRAM + * + * Only used at return from non-OFF mode. For OFF + * mode the ROM code configures the SDRC and + * the DPLL before calling the restore code directly + * from DDR. + */ + +/*

[PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM at boot and after wake-up from CORE OFF mode. However only a small part of the code really needs to run from internal SRAM. This fix lets most of the ASM idle code run from

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM at boot and after wake-up from CORE OFF mode. However only a small part of the code really needs to run from internal SRAM. This fix

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Jean Pihet
On Wed, Jun 29, 2011 at 7:29 PM, Kevin Hilman khil...@ti.com wrote: jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM at boot and after wake-up from CORE OFF mode. However only a small

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Russell King - ARM Linux
On Wed, Jun 29, 2011 at 10:29:49AM -0700, Kevin Hilman wrote: Russell, if you're OK with it, can you add it to your suspend branch for the upcoming merge window? Yes - though I think we can go a little bit further - this patch is on top of my code so far, and is untested. There isn't a need

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Kevin Hilman
Russell King - ARM Linux li...@arm.linux.org.uk writes: On Wed, Jun 29, 2011 at 10:29:49AM -0700, Kevin Hilman wrote: Russell, if you're OK with it, can you add it to your suspend branch for the upcoming merge window? Yes - though I think we can go a little bit further - this patch is on

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Russell King - ARM Linux
On Wed, Jun 29, 2011 at 06:40:23PM +0200, jean.pi...@newoldbits.com wrote: @@ -309,7 +308,7 @@ static irqreturn_t prcm_interrupt_handler (int irq, void *dev_id) static void omap34xx_do_sram_idle(unsigned long save_state) { - _omap_sram_idle(omap3_arm_context, save_state); +

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Russell King - ARM Linux
On Wed, Jun 29, 2011 at 12:06:07PM -0700, Kevin Hilman wrote: Russell King - ARM Linux li...@arm.linux.org.uk writes: On Wed, Jun 29, 2011 at 10:29:49AM -0700, Kevin Hilman wrote: Russell, if you're OK with it, can you add it to your suspend branch for the upcoming merge window? Yes -

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-29 Thread Kevin Hilman
Russell King - ARM Linux li...@arm.linux.org.uk writes: On Wed, Jun 29, 2011 at 12:06:07PM -0700, Kevin Hilman wrote: Russell King - ARM Linux li...@arm.linux.org.uk writes: On Wed, Jun 29, 2011 at 10:29:49AM -0700, Kevin Hilman wrote: Russell, if you're OK with it, can you add it to your

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-24 Thread Jean Pihet
Hi Kevin, On Fri, Jun 24, 2011 at 2:17 AM, Kevin Hilman khil...@ti.com wrote: Hi Jean, Can you rebase/retest this on top of my pm-wip/idle-suspend branch, which now contains Russell's major cleanup to use the common code as well as an additional patch from me to remove the unncessary

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-24 Thread Kevin Hilman
Jean Pihet jean.pi...@newoldbits.com writes: Hi Kevin, On Fri, Jun 24, 2011 at 2:17 AM, Kevin Hilman khil...@ti.com wrote: Hi Jean, Can you rebase/retest this on top of my pm-wip/idle-suspend branch, which now contains Russell's major cleanup to use the common code as well as an

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-23 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM and run from there. However only a small part of the code really needs to run from internal SRAM. This fix lets most of the ASM idle

[PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-17 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM and run from there. However only a small part of the code really needs to run from internal SRAM. This fix lets most of the ASM idle code run from the DDR in order to

Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-17 Thread Jean Pihet
To: Jean Pihet Cc: linux-omap@vger.kernel.org; Jean Pihet-XID Subject: RE: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR -Original Message- From: Jean Pihet [mailto:jean.pi...@newoldbits.com] Sent: Tuesday, February 01, 2011 4:53 PM To: Santosh Shilimkar Cc: linux-omap

Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-17 Thread Santosh Shilimkar
an updated patch on l-o ML: '[PATCH] OMAP3: run the ASM sleep code from DDR'. Thanks. We needed this to be in mainline. I deliberately omitted the code for WFI transition without self-refresh because of the reasons mentioned here above and repeated here (quoting myself): The DDR self refresh is enabled

Re: [PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-17 Thread Santosh Shilimkar
On 6/17/2011 2:22 PM, jean.pi...@newoldbits.com wrote: From: Jean Pihetj-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM and run from there. However only a small part of the code really needs to run from internal SRAM. This fix lets most

Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-17 Thread Kevin Hilman
to create a patch against mainline and then we take it from there. Re-pushed an updated patch on l-o ML: '[PATCH] OMAP3: run the ASM sleep code from DDR'. Thanks. We needed this to be in mainline. I deliberately omitted the code for WFI transition without self-refresh because of the reasons

Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-17 Thread Santosh Shilimkar
can't idle. I suggest you to create a patch against mainline and then we take it from there. Re-pushed an updated patch on l-o ML: '[PATCH] OMAP3: run the ASM sleep code from DDR'. Thanks. We needed this to be in mainline. I deliberately omitted the code for WFI transition without self-refresh

Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-06-16 Thread Santosh Shilimkar
code from DDR -Original Message- From: Jean Pihet [mailto:jean.pi...@newoldbits.com] Sent: Tuesday, February 01, 2011 4:53 PM To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org; Jean Pihet-XID Subject: Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR [...] Does that makes

RE: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-02-04 Thread Santosh Shilimkar
Jean, -Original Message- From: Santosh Shilimkar [mailto:santosh.shilim...@ti.com] Sent: Tuesday, February 01, 2011 5:01 PM To: Jean Pihet Cc: linux-omap@vger.kernel.org; Jean Pihet-XID Subject: RE: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR -Original Message

Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-02-01 Thread Jean Pihet
: Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR Hi Santosh, [.] +    * For OFF mode: save context and jump to WFI in SDRAM (omap3_do_wfi) +    * For non-OFF modes: jump to the WFI code in SRAM (omap3_do_wfi_sram) Why is this distinction? For non-low power modes

RE: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-02-01 Thread Santosh Shilimkar
-Original Message- From: Jean Pihet [mailto:jean.pi...@newoldbits.com] Sent: Tuesday, February 01, 2011 4:53 PM To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org; Jean Pihet-XID Subject: Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR [...] Does that makes sense

Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-01-31 Thread Jean Pihet
Pihet-XID Subject: RE: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR Jean, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of jean.pi...@newoldbits.com Sent: Thursday, January 13, 2011 9:49 PM To: linux-omap

RE: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-01-31 Thread Santosh Shilimkar
-Original Message- From: Jean Pihet [mailto:jean.pi...@newoldbits.com] Sent: Monday, January 31, 2011 4:07 PM To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org; Jean Pihet-XID Subject: Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR Hi Santosh, [.] +    * For OFF

RE: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-01-29 Thread Santosh Shilimkar
Jean, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of jean.pi...@newoldbits.com Sent: Thursday, January 13, 2011 9:49 PM To: linux-omap@vger.kernel.org Cc: Jean Pihet Subject: [RFC/PATCH] OMAP3: run the ASM sleep code

RE: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-01-29 Thread Santosh Shilimkar
-Original Message- From: Santosh Shilimkar [mailto:santosh.shilim...@ti.com] Sent: Saturday, January 29, 2011 10:45 PM To: jean.pi...@newoldbits.com; linux-omap@vger.kernel.org Cc: Jean Pihet-XID Subject: RE: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR Jean, -Original

RE: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-01-27 Thread Vishwanath Sripathy
Jean, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Jean Pihet Sent: Monday, January 24, 2011 7:59 PM To: linux-omap@vger.kernel.org Cc: Jean Pihet Subject: Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-01-27 Thread Jean Pihet
Cc: Jean Pihet Subject: Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR On Thu, Jan 13, 2011 at 5:19 PM,  jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM and run from

Re: [RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-01-24 Thread Jean Pihet
On Thu, Jan 13, 2011 at 5:19 PM, jean.pi...@newoldbits.com wrote: From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM and run from there. However only a small part of the code really needs to run from internal SRAM.

[RFC/PATCH] OMAP3: run the ASM sleep code from DDR

2011-01-13 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Most of the ASM sleep code (in arch/arm/mach-omap2/sleep34xx.S) is copied to internal SRAM and run from there. However only a small part of the code really needs to run from internal SRAM. This fix lets most of the ASM idle code run from the DDR in order to