Re: [PATCH] Staging: Westbridge: replace custom debug macros with pr_...() macros

2011-05-03 Thread Greg KH
On Thu, Apr 28, 2011 at 12:47:25PM -0700, Greg KH wrote: On Thu, Apr 28, 2011 at 11:48:41AM -0700, Sutharsan wrote: From Sutharsan Ramamoorthy s...@cypress.com This patch replaces custom debug macros with Linux kernel's pr_...() macros. Why not use the dev_dbg() and other macros instead

Re: [PATCH] Staging: Westbridge: replace custom debug macros with pr_...() macros

2011-04-28 Thread Michal Nazarewicz
On Thu, 28 Apr 2011 20:48:41 +0200, Sutharsan sutharsan.t...@gmail.com wrote: @@ -2121,7 +2121,7 @@ static int cyasgadget_initialize(void) cy_as_dev-dev_handle = cyasdevice_getdevhandle(); if (0 == cy_as_dev-dev_handle) { #ifndef NDEBUG -

Re: [PATCH] Staging: Westbridge: replace custom debug macros with pr_...() macros

2011-04-28 Thread Greg KH
On Thu, Apr 28, 2011 at 11:48:41AM -0700, Sutharsan wrote: From Sutharsan Ramamoorthy s...@cypress.com This patch replaces custom debug macros with Linux kernel's pr_...() macros. Why not use the dev_dbg() and other macros instead of these? You do have access to a struct device for all of