Re: [PATCH] driver: misc: bmp085: remove "of_match_table" property.

2012-08-07 Thread Warner Losh
On Aug 7, 2012, at 4:52 AM, Mark Brown wrote: > On Tue, Aug 07, 2012 at 08:43:44AM +0300, Felipe Balbi wrote: >> On Mon, Aug 06, 2012 at 04:42:14PM +0100, Mark Brown wrote: > >>> It's good practice to have an explict compatible string even if the >>> default happens to work in order to avoid any

Re: [PATCH] driver: misc: bmp085: remove "of_match_table" property.

2012-08-07 Thread Mark Brown
On Tue, Aug 07, 2012 at 08:43:44AM +0300, Felipe Balbi wrote: > On Mon, Aug 06, 2012 at 04:42:14PM +0100, Mark Brown wrote: > > It's good practice to have an explict compatible string even if the > > default happens to work in order to avoid any name clashes. > of_i2c.c makes no use whatsoever of

Re: [PATCH] driver: misc: bmp085: remove "of_match_table" property.

2012-08-06 Thread Felipe Balbi
Hi, On Mon, Aug 06, 2012 at 04:42:14PM +0100, Mark Brown wrote: > On Mon, Aug 06, 2012 at 12:30:34PM +0300, Felipe Balbi wrote: > > On Mon, Aug 06, 2012 at 02:58:44PM +0530, Sourav Poddar wrote: > > > There is an automatic binding done for I2C devices in the of_i2c core > > > code. So, DT will be

Re: [PATCH] driver: misc: bmp085: remove "of_match_table" property.

2012-08-06 Thread Mark Brown
On Mon, Aug 06, 2012 at 12:30:34PM +0300, Felipe Balbi wrote: > On Mon, Aug 06, 2012 at 02:58:44PM +0530, Sourav Poddar wrote: > > There is an automatic binding done for I2C devices in the of_i2c core > > code. So, DT will be able to bind to any I2C device using the > > already existing table: MODU

Re: [PATCH] driver: misc: bmp085: remove "of_match_table" property.

2012-08-06 Thread Felipe Balbi
On Mon, Aug 06, 2012 at 02:58:44PM +0530, Sourav Poddar wrote: > There is an automatic binding done for I2C devices in the of_i2c core > code. So, DT will be able to bind to any I2C device using the > already existing table: MODULE_DEVICE_TABLE(i2c, bmp085_id). > > Tested on omap5430 evm. > > Cc:

[PATCH] driver: misc: bmp085: remove "of_match_table" property.

2012-08-06 Thread Sourav Poddar
There is an automatic binding done for I2C devices in the of_i2c core code. So, DT will be able to bind to any I2C device using the already existing table: MODULE_DEVICE_TABLE(i2c, bmp085_id). Tested on omap5430 evm. Cc: Benoit Cousson Cc: Felipe Balbi Cc: Santosh Shilimkar Signed-off-by: Sour