Re: [PATCH] gpio: pcf857x: cleanup irq_demux_work and use threaded irq

2013-08-29 Thread Linus Walleij
On Thu, Aug 29, 2013 at 4:11 PM, George Cherian wrote: > On 8/29/2013 6:27 PM, Linus Walleij wrote: >>> int irq;/* real irq number */ >>> + int irq_mapped; /* mapped gpio irqs */ >> >> This seems like an u32 or atleast unsign

Re: [PATCH] gpio: pcf857x: cleanup irq_demux_work and use threaded irq

2013-08-29 Thread George Cherian
Hi Linus, Thanks for the review. I will split it and send v2. On 8/29/2013 6:27 PM, Linus Walleij wrote: On Tue, Aug 27, 2013 at 12:30 PM, George Cherian wrote: This patch - removes the irq_demux_work - Uses devm_request_threaded_irq - Call the user handler iff gpi

Re: [PATCH] gpio: pcf857x: cleanup irq_demux_work and use threaded irq

2013-08-29 Thread Linus Walleij
On Tue, Aug 27, 2013 at 12:30 PM, George Cherian wrote: > This patch > - removes the irq_demux_work > - Uses devm_request_threaded_irq > - Call the user handler iff gpio_to_irq is done. > > Signed-off-by: George Cherian Can you please split this up? It seems like three d

[PATCH] gpio: pcf857x: cleanup irq_demux_work and use threaded irq

2013-08-27 Thread George Cherian
This patch - removes the irq_demux_work - Uses devm_request_threaded_irq - Call the user handler iff gpio_to_irq is done. Signed-off-by: George Cherian --- drivers/gpio/gpio-pcf857x.c | 52 +++-- 1 file changed, 27 insertions(+), 25