Re: [PATCH] i2c: omap: fix draining irq handling

2013-01-23 Thread Wolfram Sang
On Sun, Jan 20, 2013 at 08:37:02PM +0200, Aaro Koskinen wrote: > Commit 0bdfe0cb803dce699ff337c35d8e97ac355fa417 (i2c: omap: sanitize > exit path) changed the interrupt handler to exit early and complete > the transfer after the draining IRQ is handled. As a result, the ARDY > may not be cleared pr

Re: [PATCH] i2c: omap: fix draining irq handling

2013-01-21 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 08:01:59PM +0200, Aaro Koskinen wrote: > Hi, > > On Mon, Jan 21, 2013 at 10:44:31AM +0200, Felipe Balbi wrote: > > On Sun, Jan 20, 2013 at 08:37:02PM +0200, Aaro Koskinen wrote: > > > Commit 0bdfe0cb803dce699ff337c35d8e97ac355fa417 (i2c: omap: sanitize > > > exit path)

Re: [PATCH] i2c: omap: fix draining irq handling

2013-01-21 Thread Aaro Koskinen
Hi, On Mon, Jan 21, 2013 at 10:44:31AM +0200, Felipe Balbi wrote: > On Sun, Jan 20, 2013 at 08:37:02PM +0200, Aaro Koskinen wrote: > > Commit 0bdfe0cb803dce699ff337c35d8e97ac355fa417 (i2c: omap: sanitize > > exit path) changed the interrupt handler to exit early and complete > > the transfer after

Re: [PATCH] i2c: omap: fix draining irq handling

2013-01-21 Thread Felipe Balbi
HI, On Sun, Jan 20, 2013 at 08:37:02PM +0200, Aaro Koskinen wrote: > Commit 0bdfe0cb803dce699ff337c35d8e97ac355fa417 (i2c: omap: sanitize > exit path) changed the interrupt handler to exit early and complete > the transfer after the draining IRQ is handled. As a result, the ARDY > may not be clear

[PATCH] i2c: omap: fix draining irq handling

2013-01-20 Thread Aaro Koskinen
Commit 0bdfe0cb803dce699ff337c35d8e97ac355fa417 (i2c: omap: sanitize exit path) changed the interrupt handler to exit early and complete the transfer after the draining IRQ is handled. As a result, the ARDY may not be cleared properly, and it may cause all future I2C transfers to timeout with "time