Re: [PATCH] mmc: omap_hsmmc: Fix conditional locking

2010-03-06 Thread Adrian Hunter
Thomas Gleixner wrote: Conditional locking on (!in_interrupt()) is broken by design and there is no reason to keep the host->irq_lock across the call to mmc_request_done(). Also the host->protect_card magic hack does not depend on the context Card protect does depend on not being invoked in the

RE: [PATCH] mmc: omap_hsmmc: Fix conditional locking

2010-03-03 Thread Madhusudhan
> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Wednesday, March 03, 2010 4:16 AM > To: Madhusudhan > Cc: 'LKML'; linux-omap@vger.kernel.org; linux-...@vger.kernel.org > Subject: RE: [PATCH] mmc: omap_hsmmc: Fix conditional loc

RE: [PATCH] mmc: omap_hsmmc: Fix conditional locking

2010-03-03 Thread Thomas Gleixner
On Tue, 2 Mar 2010, Madhusudhan wrote: > > Conditional locking on (!in_interrupt()) is broken by design and there > > is no reason to keep the host->irq_lock across the call to > > mmc_request_done(). Also the host->protect_card magic hack does not > > depend on the context > > > > Can you please

RE: [PATCH] mmc: omap_hsmmc: Fix conditional locking

2010-03-02 Thread Madhusudhan
> -Original Message- > From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- > ow...@vger.kernel.org] On Behalf Of Thomas Gleixner > Sent: Monday, March 01, 2010 1:02 PM > To: LKML > Cc: linux-omap@vger.kernel.org; linux-...@vger.kernel.org > Subject: [PATCH]

[PATCH] mmc: omap_hsmmc: Fix conditional locking

2010-03-01 Thread Thomas Gleixner
Conditional locking on (!in_interrupt()) is broken by design and there is no reason to keep the host->irq_lock across the call to mmc_request_done(). Also the host->protect_card magic hack does not depend on the context Fix the mess by dropping host->irq_lock before calling mmc_request_done(). Si