Re: [PATCH] omap: cleanup NAND platform data

2011-06-29 Thread Tony Lindgren
* Grazvydas Ignotas nota...@gmail.com [110603 15:01]: On Sat, Jun 4, 2011 at 12:14 AM, Vimal Singh vimal.neww...@gmail.com wrote: On Sat, Jun 4, 2011 at 1:26 AM, Grazvydas Ignotas nota...@gmail.com wrote: -static int omap2_nand_gpmc_retime(void) +static int omap2_nand_gpmc_retime(struct

[PATCH] omap: cleanup NAND platform data

2011-06-03 Thread Grazvydas Ignotas
omap_nand_platform_data fields 'options', 'gpio_irq', 'nand_setup' and 'dma_channel' are never referenced by the NAND driver, yet various board files are initializing those fields. This is both incorrect and confusing, so remove them. This allows to get rid of a global variable in gpmc-nand.c.

Re: [PATCH] omap: cleanup NAND platform data

2011-06-03 Thread Vimal Singh
On Sat, Jun 4, 2011 at 1:26 AM, Grazvydas Ignotas nota...@gmail.com wrote: omap_nand_platform_data fields 'options', 'gpio_irq', 'nand_setup' and 'dma_channel' are never referenced by the NAND driver, yet various board files are initializing those fields. This is both incorrect and confusing,

Re: [PATCH] omap: cleanup NAND platform data

2011-06-03 Thread Grazvydas Ignotas
On Sat, Jun 4, 2011 at 12:14 AM, Vimal Singh vimal.neww...@gmail.com wrote: On Sat, Jun 4, 2011 at 1:26 AM, Grazvydas Ignotas nota...@gmail.com wrote: -static int omap2_nand_gpmc_retime(void) +static int omap2_nand_gpmc_retime(struct omap_nand_platform_data *gpmc_nand_data)  {