"Premi, Sanjeev" writes:
[...]
>> > [sp] I don't like #ifdefs either but each time we cannot create
>> > a new file changes like this.
>> >
>> > The current code is a mess with debugfs used too frequently.
>> > And - all of it is not for debug. The location of ifdefs in
>> > in t
> -Original Message-
> From: Menon, Nishanth
> Sent: Thursday, May 19, 2011 7:28 PM
> To: Premi, Sanjeev
> Cc: Hilman, Kevin; linux-omap@vger.kernel.org
> Subject: Re: [PATCH] omap:pm: Fix boot-time errors with
> debugfs disabled
>
> On Thu, May 19, 2011 at 0
On Thu, May 19, 2011 at 05:30, Premi, Sanjeev wrote:
>> -Original Message-
>> From: Hilman, Kevin
>> Sent: Wednesday, May 18, 2011 10:04 PM
>> To: Premi, Sanjeev
>> Cc: linux-omap@vger.kernel.org
>> Subject: Re: [PATCH] omap:pm: Fix boot-time erro
> -Original Message-
> From: Hilman, Kevin
> Sent: Wednesday, May 18, 2011 10:04 PM
> To: Premi, Sanjeev
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH] omap:pm: Fix boot-time errors with
> debugfs disabled
>
> Hi Sanjeev,
>
> Sanjeev Premi wr
On Wed, May 18, 2011 at 11:34, Kevin Hilman wrote:
> Basically, I'm in the process of a pretty major cleanup of the VC/VP and
> SR layers. For example, in my pm-wip/voltdm_* branches, the debugfs
> interface to the voltage layer has been completely removed. I'm also
> thinking of removing the SR
Hi Sanjeev,
Sanjeev Premi writes:
> There is an implicit assumption in current implementation that
> debugfs is always enabled.
>
> When debugfs is disabled, these errors are noticed during boot:
> omap_voltage_late_init: Unable to create voltage debugfs main dir
> vdd_debugfs_init: Unable t
> -Original Message-
> From: Menon, Nishanth
> Sent: Wednesday, May 18, 2011 2:36 PM
> To: Premi, Sanjeev
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH] omap:pm: Fix boot-time errors with
> debugfs disabled
>
> On Wed, May 18, 2011 at 04:00, Premi,
On Wed, May 18, 2011 at 04:00, Premi, Sanjeev wrote:
>> While cleaning up voltdm_c set earlier this week, I think your changes
>> apply better there.
>> btw, I could incorporate a bit of your code into my patch, esp the one
>> Tony commented on http://marc.info/?l=linux-omap&m=130570559515977&w=2
> -Original Message-
> From: Menon, Nishanth
> Sent: Wednesday, May 18, 2011 1:55 PM
> To: Premi, Sanjeev
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH] omap:pm: Fix boot-time errors with
> debugfs disabled
>
> On Thu, May 12, 2011 at 1
On Thu, May 12, 2011 at 14:16, Premi, Sanjeev wrote:
[...]
>> > This patch fixes these errors by enclosing code related to debugfs
>> > in #ifdef CONFIG_DEBUG_FS..#endif.
>>
>> generic - couple of comments - I think the #defs should be isolated
>> off to headers - maybe the right approach may be t
> -Original Message-
> From: linux-omap-ow...@vger.kernel.org
> [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Premi, Sanjeev
> Sent: Friday, May 13, 2011 6:18 PM
> To: linux-omap@vger.kernel.org
> Cc: Menon, Nishanth
> Subject: RE: [PATCH] omap:pm: Fix
> -Original Message-
> From: linux-omap-ow...@vger.kernel.org
> [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Premi, Sanjeev
> Sent: Friday, May 13, 2011 12:46 AM
> To: Menon, Nishanth
> Cc: linux-omap@vger.kernel.org
> Subject: RE: [PATCH] omap:pm: Fix
On 12:58-20110512, Todd Poynor wrote:
> On Fri, May 13, 2011 at 12:46:17AM +0530, Premi, Sanjeev wrote:
> > > -Original Message-
> > > From: Menon, Nishanth
> ...
> > > Last I tried, with Vishwa's dvfs branch on panda without voltage
> > > registrations, things could crash :( if I get some
On Fri, May 13, 2011 at 12:46:17AM +0530, Premi, Sanjeev wrote:
> > -Original Message-
> > From: Menon, Nishanth
...
> > Last I tried, with Vishwa's dvfs branch on panda without voltage
> > registrations, things could crash :( if I get some time I will try to
> > port Vishwa's series onto
> -Original Message-
> From: Menon, Nishanth
> Sent: Thursday, May 12, 2011 11:32 PM
> To: Premi, Sanjeev
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH] omap:pm: Fix boot-time errors with
> debugfs disabled
>
> On Thu, May 12, 2011 at 12:36, Sanj
On Thu, May 12, 2011 at 12:36, Sanjeev Premi wrote:
> There is an implicit assumption in current implementation that
> debugfs is always enabled.
thanks for doing this.
>
> When debugfs is disabled, these errors are noticed during boot:
> omap_voltage_late_init: Unable to create voltage debugfs m
There is an implicit assumption in current implementation that
debugfs is always enabled.
When debugfs is disabled, these errors are noticed during boot:
omap_voltage_late_init: Unable to create voltage debugfs main dir
vdd_debugfs_init: Unable to create debugfs directory for vdd_mpu
vdd_deb
17 matches
Mail list logo
