Re: [PATCH] spi: ti-qspi: improve ->remove() callback

2015-11-02 Thread Grygorii Strashko
On 11/02/2015 05:20 PM, Felipe Balbi wrote: > Grygorii Strashko writes: > >> On 10/29/2015 03:57 PM, Felipe Balbi wrote: >>> there's no need to call pm_runtime_get_sync() >>> followed by pm_runtime_put(). We should, instead, >>> just call pm_runtime_put_sync() and

Re: [PATCH] spi: ti-qspi: improve ->remove() callback

2015-11-02 Thread Grygorii Strashko
On 10/29/2015 03:57 PM, Felipe Balbi wrote: there's no need to call pm_runtime_get_sync() followed by pm_runtime_put(). We should, instead, just call pm_runtime_put_sync() and pm_runtime_disable(). Sry, but why do we need to call pm_runtime_put[_sync]() here? My be just pm_runtime_disable()

Re: [PATCH] spi: ti-qspi: improve ->remove() callback

2015-11-02 Thread Felipe Balbi
Grygorii Strashko writes: > On 10/29/2015 03:57 PM, Felipe Balbi wrote: >> there's no need to call pm_runtime_get_sync() >> followed by pm_runtime_put(). We should, instead, >> just call pm_runtime_put_sync() and pm_runtime_disable(). > > Sry, but why do we need to call

Re: [PATCH] spi: ti-qspi: improve ->remove() callback

2015-11-02 Thread Grygorii Strashko
On 11/02/2015 06:06 PM, Felipe Balbi wrote: > > hi, > > Grygorii Strashko writes: >> On 11/02/2015 05:20 PM, Felipe Balbi wrote: >>> Grygorii Strashko writes: >>> On 10/29/2015 03:57 PM, Felipe Balbi wrote: > there's no need to call

Re: [PATCH] spi: ti-qspi: improve ->remove() callback

2015-11-02 Thread Felipe Balbi
Hi, Grygorii Strashko writes: > On 11/02/2015 06:06 PM, Felipe Balbi wrote: >> >> hi, >> >> Grygorii Strashko writes: >>> On 11/02/2015 05:20 PM, Felipe Balbi wrote: Grygorii Strashko writes: > On

Re: [PATCH] spi: ti-qspi: improve ->remove() callback

2015-11-02 Thread Felipe Balbi
hi, Grygorii Strashko writes: > On 11/02/2015 05:20 PM, Felipe Balbi wrote: >> Grygorii Strashko writes: >> >>> On 10/29/2015 03:57 PM, Felipe Balbi wrote: there's no need to call pm_runtime_get_sync() followed by pm_runtime_put().

[PATCH] spi: ti-qspi: improve ->remove() callback

2015-10-29 Thread Felipe Balbi
there's no need to call pm_runtime_get_sync() followed by pm_runtime_put(). We should, instead, just call pm_runtime_put_sync() and pm_runtime_disable(). Signed-off-by: Felipe Balbi --- drivers/spi/spi-ti-qspi.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-)