Re: [PATCH] usb: musb: fix pm_runtime calls while atomic

2011-11-08 Thread Felipe Balbi
On Fri, Aug 12, 2011 at 07:38:51AM -0700, Vikram Pandita wrote: From: Vikram Pandita vikram.pand...@ti.com musb pm_runtime_get_sync call happens in intrrupt context on cable attach case That can result in re-enabling the interrupts and cause side affects. So move the code to a work queue.

Re: [PATCH] usb: musb: fix pm_runtime calls while atomic

2011-08-25 Thread Pandita, Vikram
Felipe On Fri, Aug 12, 2011 at 10:21 AM, Pandita, Vikram vikram.pand...@ti.com wrote: On Fri, Aug 12, 2011 at 10:04 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 12 Aug 2011, Pandita, Vikram wrote: On Fri, Aug 12, 2011 at 8:50 AM, Alan Stern st...@rowland.harvard.edu wrote:

[PATCH] usb: musb: fix pm_runtime calls while atomic

2011-08-12 Thread Vikram Pandita
From: Vikram Pandita vikram.pand...@ti.com musb pm_runtime_get_sync call happens in intrrupt context on cable attach case That can result in re-enabling the interrupts and cause side affects. So move the code to a work queue. Following is the error path hit on cable attach: BUG: sleeping

Re: [PATCH] usb: musb: fix pm_runtime calls while atomic

2011-08-12 Thread Alan Stern
On Fri, 12 Aug 2011, Vikram Pandita wrote: From: Vikram Pandita vikram.pand...@ti.com musb pm_runtime_get_sync call happens in intrrupt context on cable attach case That can result in re-enabling the interrupts and cause side affects. So move the code to a work queue. Instead of creating

Re: [PATCH] usb: musb: fix pm_runtime calls while atomic

2011-08-12 Thread Pandita, Vikram
On Fri, Aug 12, 2011 at 8:50 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 12 Aug 2011, Vikram Pandita wrote: From: Vikram Pandita vikram.pand...@ti.com musb pm_runtime_get_sync call happens in intrrupt context on cable attach case That can result in re-enabling the interrupts

Re: [PATCH] usb: musb: fix pm_runtime calls while atomic

2011-08-12 Thread Alan Stern
On Fri, 12 Aug 2011, Pandita, Vikram wrote: On Fri, Aug 12, 2011 at 8:50 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 12 Aug 2011, Vikram Pandita wrote: From: Vikram Pandita vikram.pand...@ti.com musb pm_runtime_get_sync call happens in intrrupt context on cable attach

Re: [PATCH] usb: musb: fix pm_runtime calls while atomic

2011-08-12 Thread Pandita, Vikram
On Fri, Aug 12, 2011 at 10:04 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 12 Aug 2011, Pandita, Vikram wrote: On Fri, Aug 12, 2011 at 8:50 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 12 Aug 2011, Vikram Pandita wrote: From: Vikram Pandita