Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-09 Thread Peter Zijlstra
On Mon, Feb 09, 2015 at 10:27:32AM +0200, Peter Ujfalusi wrote: As I recall there is a plan to remove the hwmod static database and move it or generate it from DT? Not sure when and how this will be done, but will it affect the lockdep_set_class() way? Yes, struct lock_class_key wants to be in

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-09 Thread Paul Walmsley
On Mon, 9 Feb 2015, Peter Ujfalusi wrote: On 02/06/2015 09:26 PM, Peter Ujfalusi wrote: Yeah, I've never really bothered with data too much, its a debug feature. So lock_class_key is 8 bytes, and strictly speaking you could union them over other fields, all we really need is unique

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-09 Thread Paul Walmsley
On Mon, 9 Feb 2015, Tony Lindgren wrote: * Paul Walmsley p...@pwsan.com [150209 08:04]: On Mon, 9 Feb 2015, Peter Ujfalusi wrote: On 02/06/2015 09:26 PM, Peter Ujfalusi wrote: Yeah, I've never really bothered with data too much, its a debug feature. So lock_class_key is 8 bytes,

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-09 Thread Peter Ujfalusi
On 02/06/2015 09:26 PM, Peter Ujfalusi wrote: Yeah, I've never really bothered with data too much, its a debug feature. So lock_class_key is 8 bytes, and strictly speaking you could union them over other fields, all we really need is unique addresses, we don't actually use the storage.

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-09 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [150209 08:04]: On Mon, 9 Feb 2015, Peter Ujfalusi wrote: On 02/06/2015 09:26 PM, Peter Ujfalusi wrote: Yeah, I've never really bothered with data too much, its a debug feature. So lock_class_key is 8 bytes, and strictly speaking you could union them

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-09 Thread Tony Lindgren
* Paul Walmsley p...@pwsan.com [150209 10:59]: On Mon, 9 Feb 2015, Tony Lindgren wrote: * Paul Walmsley p...@pwsan.com [150209 08:04]: On Mon, 9 Feb 2015, Peter Ujfalusi wrote: On 02/06/2015 09:26 PM, Peter Ujfalusi wrote: Yeah, I've never really bothered with data too much,

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-06 Thread Peter Ujfalusi
On 02/06/2015 08:32 PM, Peter Zijlstra wrote: On Fri, Feb 06, 2015 at 06:05:32PM +0200, Peter Ujfalusi wrote: Certainly looks much simpler, but it adds quite a bit of data to the omap_hwmod struct, and we have a _lot_ of them for omap2plus configuration. ls -al vmlinux w/o any the lockdep

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-06 Thread Peter Zijlstra
On Fri, Feb 06, 2015 at 02:48:34PM +0200, Peter Ujfalusi wrote: Hi, In case when hwmods are used in nested way the lockdep validator will print out a warning message about possible deadlock situation: [4.514882] = [4.520530] [ INFO:

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-06 Thread Peter Ujfalusi
On 02/06/2015 04:13 PM, Peter Zijlstra wrote: On Fri, Feb 06, 2015 at 02:48:34PM +0200, Peter Ujfalusi wrote: Hi, In case when hwmods are used in nested way the lockdep validator will print out a warning message about possible deadlock situation: [4.514882]

[PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-06 Thread Peter Ujfalusi
Hi, In case when hwmods are used in nested way the lockdep validator will print out a warning message about possible deadlock situation: [4.514882] = [4.520530] [ INFO: possible recursive locking detected ] [4.526176]

Re: [PATCH 0/2] ARM: omap2+: omap_hwmod: Fix false lockdep warning

2015-02-06 Thread Peter Zijlstra
On Fri, Feb 06, 2015 at 06:05:32PM +0200, Peter Ujfalusi wrote: Certainly looks much simpler, but it adds quite a bit of data to the omap_hwmod struct, and we have a _lot_ of them for omap2plus configuration. ls -al vmlinux w/o any the lockdep warning fixes: 110109168 With my series