Re: [PATCH 0/4] bq27x00 updates

2008-10-18 Thread Anton Vorontsov
On Sun, Oct 19, 2008 at 01:23:43AM +0300, Felipe Balbi wrote: > On Sun, Oct 19, 2008 at 01:16:43AM +0400, Anton Vorontsov wrote: > > On Sat, Oct 18, 2008 at 12:00:44AM +0300, Felipe Balbi wrote: > > > The previous driver for bq27x00 batteries was a real > > > ifdef mess. The following patches separ

Re: [PATCH 0/4] bq27x00 updates

2008-10-18 Thread Felipe Balbi
On Sun, Oct 19, 2008 at 01:16:43AM +0400, Anton Vorontsov wrote: > On Sat, Oct 18, 2008 at 12:00:44AM +0300, Felipe Balbi wrote: > > The previous driver for bq27x00 batteries was a real > > ifdef mess. The following patches separate common code > > and create separate drivers for bq27200 and bq2700

Re: [PATCH 0/4] bq27x00 updates

2008-10-18 Thread Anton Vorontsov
On Sat, Oct 18, 2008 at 12:00:44AM +0300, Felipe Balbi wrote: > The previous driver for bq27x00 batteries was a real > ifdef mess. The following patches separate common code > and create separate drivers for bq27200 and bq27000. FYI (if you don't know already): Rodolfo Giometti already cleaned up

Re: [PATCH 0/4] bq27x00 updates

2008-10-17 Thread Felipe Balbi
On Sat, Oct 18, 2008 at 01:40:06AM +0400, Anton Vorontsov wrote: > One thing though: we can't delete the old driver now. I'm about > to send a pull request to Linus. Though I think we can hurry up and > merge the new driver for 2.6.28, but delete the old one in 2.6.29. > > This means that you migh

Re: [PATCH 0/4] bq27x00 updates

2008-10-17 Thread Anton Vorontsov
Hi Felipe, On Sat, Oct 18, 2008 at 12:00:44AM +0300, Felipe Balbi wrote: > The previous driver for bq27x00 batteries was a real > ifdef mess. The following patches separate common code > and create separate drivers for bq27200 and bq27000. > > The code looks much cleaner, but we had to keep a glo

[PATCH 0/4] bq27x00 updates

2008-10-17 Thread Felipe Balbi
The previous driver for bq27x00 batteries was a real ifdef mess. The following patches separate common code and create separate drivers for bq27200 and bq27000. The code looks much cleaner, but we had to keep a global static pointer to hold the i2c_client (bq27200) or the w1 device (bq27000). If