Re: [PATCH 01/11] spi: Provide core support for runtime PM during transfers

2013-07-29 Thread Stephen Warren
On 07/28/2013 08:43 AM, Mark Brown wrote: From: Mark Brown broo...@linaro.org Most SPI drivers that implement runtime PM support use identical code to do so: they acquire a runtime PM lock in prepare_transfer_hardware() and then they release it in unprepare_transfer_hardware(). The

[PATCH 01/11] spi: Provide core support for runtime PM during transfers

2013-07-28 Thread Mark Brown
From: Mark Brown broo...@linaro.org Most SPI drivers that implement runtime PM support use identical code to do so: they acquire a runtime PM lock in prepare_transfer_hardware() and then they release it in unprepare_transfer_hardware(). The variations in this are mostly missing error checking and

Re: [PATCH 01/11] spi: Provide core support for runtime PM during transfers

2013-07-28 Thread Linus Walleij
On Sun, Jul 28, 2013 at 4:43 PM, Mark Brown broo...@kernel.org wrote: Most SPI drivers that implement runtime PM support use identical code to do so: they acquire a runtime PM lock in prepare_transfer_hardware() and then they release it in unprepare_transfer_hardware(). The variations in this

Re: [PATCH 01/11] spi: Provide core support for runtime PM during transfers

2013-07-28 Thread Mark Brown
On Sun, Jul 28, 2013 at 10:51:31PM +0200, Linus Walleij wrote: On Sun, Jul 28, 2013 at 4:43 PM, Mark Brown broo...@kernel.org wrote: + * @auto_runtime_pm: the core should ensure a runtime PM reference is held + * while the hardware is prepared I'd mention here that the