Re: [PATCH 01/16] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found

2012-02-09 Thread Tony Lindgren
* Russell King - ARM Linux [120209 08:13]: > On Wed, Feb 08, 2012 at 03:46:54PM -0800, Tony Lindgren wrote: > > * Tony Lindgren [120208 10:02]: > > > * Russell King - ARM Linux [120208 08:05]: > > > > > > This is better than Kevin's earlier patch because of the descriptive > > > error: > > > >

Re: [PATCH 01/16] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found

2012-02-09 Thread Russell King - ARM Linux
On Wed, Feb 08, 2012 at 03:46:54PM -0800, Tony Lindgren wrote: > * Tony Lindgren [120208 10:02]: > > * Russell King - ARM Linux [120208 08:05]: > > > > This is better than Kevin's earlier patch because of the descriptive > > error: > > > > Acked-by: Tony Lindgren > > Hmm looks like the patch

Re: [PATCH 01/16] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found

2012-02-08 Thread Tony Lindgren
* Tony Lindgren [120208 10:02]: > * Russell King - ARM Linux [120208 08:05]: > > This is better than Kevin's earlier patch because of the descriptive > error: > > Acked-by: Tony Lindgren Hmm looks like the patch from Ahilash that Kevin queued has the also a test for missing uv_to_vsel: if (!

Re: [PATCH 01/16] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found

2012-02-08 Thread Tony Lindgren
* Russell King - ARM Linux [120208 08:05]: > When the PMIC is not found, voltdm->pmic will be NULL. vp.c's > initialization function tries to dereferences this, which causes an > oops: > > Unable to handle kernel NULL pointer dereference at virtual address > pgd = c0004000 > []

[PATCH 01/16] ARM: omap: fix oops in arch/arm/mach-omap2/vp.c when pmic is not found

2012-02-08 Thread Russell King - ARM Linux
When the PMIC is not found, voltdm->pmic will be NULL. vp.c's initialization function tries to dereferences this, which causes an oops: Unable to handle kernel NULL pointer dereference at virtual address pgd = c0004000 [] *pgd= Internal error: Oops: 5 [#1] PREEMPT Modules