Re: [PATCH 01/28] OMAP3: PM: GPMC context save/restore

2009-10-05 Thread Nishanth Menon
Kevin Hilman had written, on 10/05/2009 01:15 PM, the following: + gpmc_cs_read_reg(i, GPMC_CS_CONFIG7); + } here is a theoretical bug: 1: GPMC, 1, 2, 3 4 5 configured 6 7 not configured. 2. Save and restore 1: save and restore variables which are s

Re: [PATCH 01/28] OMAP3: PM: GPMC context save/restore

2009-10-05 Thread Kevin Hilman
Nishanth Menon writes: > Kevin Hilman had written, on 10/05/2009 12:29 PM, the following: >> Nishanth Menon writes: > + gpmc_context.cs_context[i].is_valid = + (gpmc_cs_read_reg(i, GPMC_CS_CONFIG7)) +

Re: [PATCH 01/28] OMAP3: PM: GPMC context save/restore

2009-10-05 Thread Nishanth Menon
Kevin Hilman had written, on 10/05/2009 12:29 PM, the following: Nishanth Menon writes: + gpmc_context.cs_context[i].is_valid = + (gpmc_cs_read_reg(i, GPMC_CS_CONFIG7)) + & GPMC_CONFIG7_CSVALID;

Re: [PATCH 01/28] OMAP3: PM: GPMC context save/restore

2009-10-05 Thread Kevin Hilman
Nishanth Menon writes: [...] >> +void omap3_gpmc_save_context() >> +{ >> +int i; >> +gpmc_context.sysconfig = gpmc_read_reg(GPMC_SYSCONFIG); >> +gpmc_context.irqenable = gpmc_read_reg(GPMC_IRQENABLE); >> +gpmc_context.timeout_ctrl = gpmc_read_reg(GPMC_TIMEOUT_CONTROL); >> +gp

Re: [PATCH 01/28] OMAP3: PM: GPMC context save/restore

2009-10-05 Thread Nishanth Menon
Kevin Hilman had written, on 10/05/2009 12:17 PM, the following: +#ifdef CONFIG_ARCH_OMAP3 apologies if this is a dumb question - why is this under #ifdef -> if the save save restore structures are not under #ifdef? Not a dumb question, good catch. I'll move the struct inside this #ifdef.

Re: [PATCH 01/28] OMAP3: PM: GPMC context save/restore

2009-10-05 Thread Kevin Hilman
Nishanth Menon writes: > Kevin Hilman said the following on 10/01/2009 06:58 PM: >> From: Rajendra Nayak >> >> This patch adds the context save restore functions for GPMC >> >> Signed-off-by: Rajendra Nayak >> --- >> arch/arm/mach-omap2/gpmc.c | 93 >> +++

Re: [PATCH 01/28] OMAP3: PM: GPMC context save/restore

2009-10-03 Thread Nishanth Menon
Kevin Hilman said the following on 10/01/2009 06:58 PM: > From: Rajendra Nayak > > This patch adds the context save restore functions for GPMC > > Signed-off-by: Rajendra Nayak > --- > arch/arm/mach-omap2/gpmc.c | 93 > > arch/arm/plat-omap/include

[PATCH 01/28] OMAP3: PM: GPMC context save/restore

2009-10-01 Thread Kevin Hilman
From: Rajendra Nayak This patch adds the context save restore functions for GPMC Signed-off-by: Rajendra Nayak --- arch/arm/mach-omap2/gpmc.c | 93 arch/arm/plat-omap/include/mach/gpmc.h |3 + 2 files changed, 96 insertions(+), 0 deletions(-)