Re: [PATCH 02/10] ARM: OMAP: Fix sparse, checkpatch warnings in OMAP2/3 PRCM/PM code

2008-10-06 Thread Paul Walmsley
Hello Russell, On Sat, 4 Oct 2008, Russell King - ARM Linux wrote: On Thu, Oct 02, 2008 at 10:37:50AM -0600, Paul Walmsley wrote: static void omap2_clk_wait_ready(struct clk *clk) { - void __iomem *reg, *other_reg, *st_reg; - u32 bit; - - /* -* REVISIT: This code is

Re: [PATCH 02/10] ARM: OMAP: Fix sparse, checkpatch warnings in OMAP2/3 PRCM/PM code

2008-10-06 Thread Russell King - ARM Linux
On Mon, Oct 06, 2008 at 08:52:46AM -0600, Paul Walmsley wrote: OK. Tony's tree contains some patches which thoroughly clean this function up, but they are large. Would you like me to send those along with this patch set, or would you prefer that I just drop this part of the patch and

Re: [PATCH 02/10] ARM: OMAP: Fix sparse, checkpatch warnings in OMAP2/3 PRCM/PM code

2008-10-06 Thread Paul Walmsley
On Mon, 6 Oct 2008, Russell King - ARM Linux wrote: On Mon, Oct 06, 2008 at 08:52:46AM -0600, Paul Walmsley wrote: OK. Tony's tree contains some patches which thoroughly clean this function up, but they are large. Would you like me to send those along with this patch set, or would you

Re: [PATCH 02/10] ARM: OMAP: Fix sparse, checkpatch warnings in OMAP2/3 PRCM/PM code

2008-10-04 Thread Russell King - ARM Linux
On Thu, Oct 02, 2008 at 10:37:50AM -0600, Paul Walmsley wrote: static void omap2_clk_wait_ready(struct clk *clk) { - void __iomem *reg, *other_reg, *st_reg; - u32 bit; - - /* - * REVISIT: This code is pretty ugly. It would be nice to generalize - * it and pull it

[PATCH 02/10] ARM: OMAP: Fix sparse, checkpatch warnings in OMAP2/3 PRCM/PM code

2008-10-02 Thread Paul Walmsley
Fix sparse checkpatch warnings in OMAP2/3 PRCM PM code. This mostly consists of: - converting pointer comparisons to integers in form similar to (ptr == 0) to the standard idiom (!ptr) - labeling a few non-static private functions as static - adding prototypes for *_init() functions in the