Re: [PATCH 03/17] spi/qspi: parse register by name.

2013-11-28 Thread Mark Brown
On Thu, Nov 28, 2013 at 10:15:14AM +0530, Sourav Poddar wrote: On Tuesday 26 November 2013 05:54 PM, Mark Brown wrote: Do device tree binding changes early on in the series rather than at the end, one of the things that gets reviewed for is binding updates. Your code should also cope with

Re: [PATCH 03/17] spi/qspi: parse register by name.

2013-11-28 Thread Sourav Poddar
On Thursday 28 November 2013 04:24 PM, Mark Brown wrote: On Thu, Nov 28, 2013 at 10:15:14AM +0530, Sourav Poddar wrote: On Tuesday 26 November 2013 05:54 PM, Mark Brown wrote: Do device tree binding changes early on in the series rather than at the end, one of the things that gets reviewed for

Re: [PATCH 03/17] spi/qspi: parse register by name.

2013-11-28 Thread Mark Brown
On Thu, Nov 28, 2013 at 04:28:07PM +0530, Sourav Poddar wrote: On Thursday 28 November 2013 04:24 PM, Mark Brown wrote: That means that if you switch all resources to _byname then the driver won't find any resources at all and will fail. This will in turn mean that any device trees that work

Re: [PATCH 03/17] spi/qspi: parse register by name.

2013-11-28 Thread Sourav Poddar
On Thursday 28 November 2013 04:41 PM, Mark Brown wrote: On Thu, Nov 28, 2013 at 04:28:07PM +0530, Sourav Poddar wrote: On Thursday 28 November 2013 04:24 PM, Mark Brown wrote: That means that if you switch all resources to _byname then the driver won't find any resources at all and will fail.

Re: [PATCH 03/17] spi/qspi: parse register by name.

2013-11-27 Thread Sourav Poddar
On Tuesday 26 November 2013 05:54 PM, Mark Brown wrote: On Tue, Nov 26, 2013 at 04:47:49PM +0530, Sourav Poddar wrote: I have added reg-names property in dt bindings. (17/17) patch of this series has that info. Do device tree binding changes early on in the series rather than at the end, one

Re: [PATCH 03/17] spi/qspi: parse register by name.

2013-11-26 Thread Mark Brown
On Tue, Nov 26, 2013 at 01:04:59PM +0530, Sourav Poddar wrote: Modify the qspi driver to parse reg information by name. This presumably needs an update to the device tree bindings so that there's a name defined? signature.asc Description: Digital signature

Re: [PATCH 03/17] spi/qspi: parse register by name.

2013-11-26 Thread Sourav Poddar
On Tuesday 26 November 2013 04:00 PM, Mark Brown wrote: On Tue, Nov 26, 2013 at 01:04:59PM +0530, Sourav Poddar wrote: Modify the qspi driver to parse reg information by name. This presumably needs an update to the device tree bindings so that there's a name defined? I have added reg-names

Re: [PATCH 03/17] spi/qspi: parse register by name.

2013-11-26 Thread Mark Brown
On Tue, Nov 26, 2013 at 04:47:49PM +0530, Sourav Poddar wrote: I have added reg-names property in dt bindings. (17/17) patch of this series has that info. Do device tree binding changes early on in the series rather than at the end, one of the things that gets reviewed for is binding updates.

[PATCH 03/17] spi/qspi: parse register by name.

2013-11-25 Thread Sourav Poddar
Modify the qspi driver to parse reg information by name. Signed-off-by: Sourav Poddar sourav.pod...@ti.com --- drivers/spi/spi-ti-qspi.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c index 033ef8d..67aa905