[PATCH 04/15] ARM: OMAP2+: hwmod: Update the reset API for AM33XX

2012-11-02 Thread Vaibhav Bedia
WKUP-M3 has a reset status bit (RM_WKUP_STST.WKUP_M3_LRST) Update the hardreset API to take care of the same to ensure that the reset line properly deasserted. Signed-off-by: Vaibhav Bedia --- arch/arm/mach-omap2/omap_hwmod.c |5 + arch/arm/mach-omap2/prm33xx.c| 15 +++

Re: [PATCH 04/15] ARM: OMAP2+: hwmod: Update the reset API for AM33XX

2012-11-04 Thread Vaibhav Hiremath
On 11/2/2012 6:02 PM, Vaibhav Bedia wrote: > WKUP-M3 has a reset status bit (RM_WKUP_STST.WKUP_M3_LRST) > Update the hardreset API to take care of the same to ensure > that the reset line properly deasserted. > Thanks for the patch, comments below - > Signed-off-by: Vaibhav Bedia > --- > arc

RE: [PATCH 04/15] ARM: OMAP2+: hwmod: Update the reset API for AM33XX

2012-11-05 Thread Bedia, Vaibhav
On Mon, Nov 05, 2012 at 12:28:36, Hiremath, Vaibhav wrote: [...] > > - u32 mask = 1 << shift; > > - > > - /* Check the current status to avoid de-asserting the line twice */ > > - if (am33xx_prm_is_hardreset_asserted(shift, inst, rstctrl_offs) == 0) > > - return -EEXIST; > > Any s

RE: [PATCH 04/15] ARM: OMAP2+: hwmod: Update the reset API for AM33XX

2012-11-05 Thread Hiremath, Vaibhav
On Mon, Nov 05, 2012 at 23:27:52, Bedia, Vaibhav wrote: > On Mon, Nov 05, 2012 at 12:28:36, Hiremath, Vaibhav wrote: > [...] > > > - u32 mask = 1 << shift; > > > - > > > - /* Check the current status to avoid de-asserting the line twice */ > > > - if (am33xx_prm_is_hardreset_asserted(shift, inst,

RE: [PATCH 04/15] ARM: OMAP2+: hwmod: Update the reset API for AM33XX

2012-11-05 Thread Bedia, Vaibhav
On Tue, Nov 06, 2012 at 11:36:20, Hiremath, Vaibhav wrote: [...] > > The code is checking whether the line is already de-asserted (== 0), so I am > not sure how this will change if hardreset line is asserted during bootup. You are right. I just checked the behavior since I recall seeing somethi