Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-07-04 Thread Sekhar Nori
On 7/4/2013 7:20 PM, Sebastian Andrzej Siewior wrote: > On 07/04/2013 03:39 PM, Sekhar Nori wrote: >> Yes, I noticed that after sending the mail. To me it does not make sense >> to make changes to accept something as platform data only to remove >> platform data itself later. > > The patches were

Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-07-04 Thread Sebastian Andrzej Siewior
On 07/04/2013 03:39 PM, Sekhar Nori wrote: > Yes, I noticed that after sending the mail. To me it does not make sense > to make changes to accept something as platform data only to remove > platform data itself later. The patches were made earlier and it was easier that way to take everything and

Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-07-04 Thread Sekhar Nori
On 7/4/2013 5:03 PM, Sebastian Andrzej Siewior wrote: > On 07/04/2013 01:14 PM, Sekhar Nori wrote: >> >> On 6/11/2013 5:00 PM, Sebastian Andrzej Siewior wrote: >>> From: "Patil, Rachna" >>> >>> The current driver expected touchscreen input >>> wires(XP,XN,YP,YN) to be connected in a particular ord

Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-07-04 Thread Sebastian Andrzej Siewior
On 07/04/2013 01:14 PM, Sekhar Nori wrote: > > On 6/11/2013 5:00 PM, Sebastian Andrzej Siewior wrote: >> From: "Patil, Rachna" >> >> The current driver expected touchscreen input >> wires(XP,XN,YP,YN) to be connected in a particular order. >> Making changes to accept this as platform data > > Th

Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-07-04 Thread Sekhar Nori
On 6/11/2013 5:00 PM, Sebastian Andrzej Siewior wrote: > From: "Patil, Rachna" > > The current driver expected touchscreen input > wires(XP,XN,YP,YN) to be connected in a particular order. > Making changes to accept this as platform data The platform data part of this driver will never get used

Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-06-11 Thread Sebastian Andrzej Siewior
On 06/11/2013 04:23 PM, Samuel Ortiz wrote: > Hi Sebastian, Hi Samuel, > On Tue, Jun 11, 2013 at 01:30:50PM +0200, Sebastian Andrzej Siewior wrote: >> diff --git a/include/linux/mfd/ti_am335x_tscadc.h >> b/include/linux/mfd/ti_am335x_tscadc.h >> index eeead15..2d78af8 100644 >> --- a/include/lin

Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-06-11 Thread Samuel Ortiz
Hi Sebastian, On Tue, Jun 11, 2013 at 01:30:50PM +0200, Sebastian Andrzej Siewior wrote: > diff --git a/include/linux/mfd/ti_am335x_tscadc.h > b/include/linux/mfd/ti_am335x_tscadc.h > index eeead15..2d78af8 100644 > --- a/include/linux/mfd/ti_am335x_tscadc.h > +++ b/include/linux/mfd/ti_am335x_ts

[PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-06-11 Thread Sebastian Andrzej Siewior
From: "Patil, Rachna" The current driver expected touchscreen input wires(XP,XN,YP,YN) to be connected in a particular order. Making changes to accept this as platform data. Signed-off-by: Patil, Rachna Signed-off-by: Felipe Balbi [bigeasy: larger rework of the patch, no config[4][4] array, sm