Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

2011-02-21 Thread Felipe Balbi
Hi, On Mon, Feb 21, 2011 at 04:05:14PM +0200, David Cohen wrote: > On Mon, Feb 21, 2011 at 3:57 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Feb 21, 2011 at 03:51:25PM +0200, Alexey Dobriyan wrote: > >> > I rather have the split done and kill the circular dependency. > >> > >> It's not circula

Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

2011-02-21 Thread David Cohen
On Mon, Feb 21, 2011 at 3:57 PM, Felipe Balbi wrote: > Hi, > > On Mon, Feb 21, 2011 at 03:51:25PM +0200, Alexey Dobriyan wrote: >> > I rather have the split done and kill the circular dependency. >> >> It's not circular for starters. > > how come ? wait.h depends on sched and sched.h depends on wa

Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

2011-02-21 Thread Felipe Balbi
Hi, On Mon, Feb 21, 2011 at 03:51:25PM +0200, Alexey Dobriyan wrote: > > I rather have the split done and kill the circular dependency. > > It's not circular for starters. how come ? wait.h depends on sched and sched.h depends on wait.h -- balbi -- To unsubscribe from this list: send the line

Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

2011-02-21 Thread Alexey Dobriyan
On Mon, Feb 21, 2011 at 2:30 PM, Felipe Balbi wrote: > On Mon, Feb 21, 2011 at 01:05:51PM +0200, Alexey Dobriyan wrote: >> Just include in your driver. >> This include splitting in small pieces is troublesome as well. > > so, simply to call wake_up*() we need to know everything there is to > kno

Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

2011-02-21 Thread Felipe Balbi
On Mon, Feb 21, 2011 at 01:05:51PM +0200, Alexey Dobriyan wrote: > On Mon, Feb 21, 2011 at 12:20 PM, David Cohen wrote: > > Currently sched.h and wait.h have circular dependency between both. > > wait.h defines macros wake_up*() which use macros TASK_* defined by > > sched.h. But as sched.h indire

Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

2011-02-21 Thread David Cohen
On Mon, Feb 21, 2011 at 1:05 PM, Alexey Dobriyan wrote: > On Mon, Feb 21, 2011 at 12:20 PM, David Cohen wrote: >> Currently sched.h and wait.h have circular dependency between both. >> wait.h defines macros wake_up*() which use macros TASK_* defined by >> sched.h. But as sched.h indirectly includ

Re: [PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

2011-02-21 Thread Alexey Dobriyan
On Mon, Feb 21, 2011 at 12:20 PM, David Cohen wrote: > Currently sched.h and wait.h have circular dependency between both. > wait.h defines macros wake_up*() which use macros TASK_* defined by > sched.h. But as sched.h indirectly includes wait.h, such wait.h header > file can't include sched.h too

[PATCH 1/1] headers: fix circular dependency between linux/sched.h and linux/wait.h

2011-02-21 Thread David Cohen
Currently sched.h and wait.h have circular dependency between both. wait.h defines macros wake_up*() which use macros TASK_* defined by sched.h. But as sched.h indirectly includes wait.h, such wait.h header file can't include sched.h too. The side effect is when some file includes wait.h and tries