On Wed, 2010-10-06 at 10:33 +0400, Evgeny Kuznetsov wrote:
> On Tue, 2010-10-05 at 08:01 -0700, ext Kevin Hilman wrote:
> > Felipe Balbi writes:
> >
> > > Hi,
> > >
> > > On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
> > >>+ if (!isr_reg) {
> > >>+ printk(KERN_ERR "FAT
On Tue, 2010-10-05 at 08:01 -0700, ext Kevin Hilman wrote:
> Felipe Balbi writes:
>
> > Hi,
> >
> > On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
> >>+ if (!isr_reg) {
> >>+ printk(KERN_ERR "FATAL: Incorrect GPIO method %i\n",
> >>+ bank->
Felipe Balbi writes:
> Hi,
>
> On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
>>+ if (!isr_reg) {
>>+ printk(KERN_ERR "FATAL: Incorrect GPIO method %i\n",
>>+ bank->method);
>>+ BUG();
>>+ }
>
> this could be s
Hi,
(don't top post)
On Tue, Oct 05, 2010 at 04:55:19AM -0500, Evgeny Kuznetsov wrote:
Yes, but no log in that case.
what do you call the stack dump BUG() shows ??
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.ker
Hi,
Yes, but no log in that case.
Regards,
Evgeny
On Tue, 2010-10-05 at 12:32 +0300, ext Felipe Balbi wrote:
> Hi,
>
> On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
> >+if (!isr_reg) {
> >+printk(KERN_ERR "FATAL: Incorrect GPIO method %i\n",
> >+
Hi,
On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
+ if (!isr_reg) {
+ printk(KERN_ERR "FATAL: Incorrect GPIO method %i\n",
+ bank->method);
+ BUG();
+ }
this could be simply:
BUG_ON(!isr_reg);
-
From: Evgeny Kuznetsov
Value of "isr_reg" pointer is depend on configuration and GPIO method.
Potentially it may have NULL value and it is dereferenced later
in code. If pointer is NULL there is some kernel bug.
Log line and 'BUG' macro are added to halt code execution in this case.
Signed-off-
