Re: [PATCH 1/2] ARM: OMAP2: Fix definition of SGX clock register bits

2008-09-12 Thread Tony Lindgren
* Daniel Stone <[EMAIL PROTECTED]> [080912 08:31]: > On Wed, Sep 10, 2008 at 05:13:03PM -0700, ext Tony Lindgren wrote: > > * Daniel Stone <[EMAIL PROTECTED]> [080827 02:47]: > > > On Wed, Aug 27, 2008 at 12:50:37AM -0600, ext Paul Walmsley wrote: > > > > Hello Daniel, > > > > > > > > On Wed, 27 A

Re: [PATCH 1/2] ARM: OMAP2: Fix definition of SGX clock register bits

2008-09-12 Thread Daniel Stone
On Wed, Sep 10, 2008 at 05:13:03PM -0700, ext Tony Lindgren wrote: > * Daniel Stone <[EMAIL PROTECTED]> [080827 02:47]: > > On Wed, Aug 27, 2008 at 12:50:37AM -0600, ext Paul Walmsley wrote: > > > Hello Daniel, > > > > > > On Wed, 27 Aug 2008, Daniel Stone wrote: > > > > > > > Yep, looks fine to

Re: [PATCH 1/2] ARM: OMAP2: Fix definition of SGX clock register bits

2008-09-10 Thread Tony Lindgren
* Daniel Stone <[EMAIL PROTECTED]> [080827 02:47]: > On Wed, Aug 27, 2008 at 12:50:37AM -0600, ext Paul Walmsley wrote: > > Hello Daniel, > > > > On Wed, 27 Aug 2008, Daniel Stone wrote: > > > > > Yep, looks fine to me: just wasn't really sure what to put. Should I > > > resend, or? > > > > yes

Re: [PATCH 1/2] ARM: OMAP2: Fix definition of SGX clock register bits

2008-08-27 Thread Daniel Stone
On Wed, Aug 27, 2008 at 12:50:37AM -0600, ext Paul Walmsley wrote: > Hello Daniel, > > On Wed, 27 Aug 2008, Daniel Stone wrote: > > > Yep, looks fine to me: just wasn't really sure what to put. Should I > > resend, or? > > yes, please resend - that will make it convenient for Tony to apply the

Re: [PATCH 1/2] ARM: OMAP2: Fix definition of SGX clock register bits

2008-08-26 Thread Paul Walmsley
Hello Daniel, On Wed, 27 Aug 2008, Daniel Stone wrote: > Yep, looks fine to me: just wasn't really sure what to put. Should I > resend, or? yes, please resend - that will make it convenient for Tony to apply the patches. regards, - Paul -- To unsubscribe from this list: send the line "unsub

Re: [PATCH 1/2] ARM: OMAP2: Fix definition of SGX clock register bits

2008-08-26 Thread Daniel Stone
On Tue, Aug 26, 2008 at 11:05:42PM -0600, ext Paul Walmsley wrote: > Hello Daniel, Hi, > On Wed, 27 Aug 2008, Daniel Stone wrote: > > The GFX/SGX functional and interface clocks have different masks, for > > some unknown reason, so split EN_SGX_SHIFT into one each for fclk and > > iclk. > > than

Re: [PATCH 1/2] ARM: OMAP2: Fix definition of SGX clock register bits

2008-08-26 Thread Paul Walmsley
Hello Daniel, On Wed, 27 Aug 2008, Daniel Stone wrote: > The GFX/SGX functional and interface clocks have different masks, for > some unknown reason, so split EN_SGX_SHIFT into one each for fclk and > iclk. thanks for the fix, this looks mostly good - one comment: > diff --git a/arch/arm/mach-o

[PATCH 1/2] ARM: OMAP2: Fix definition of SGX clock register bits

2008-08-26 Thread Daniel Stone
The GFX/SGX functional and interface clocks have different masks, for some unknown reason, so split EN_SGX_SHIFT into one each for fclk and iclk. Correct according to the TRM and the far more important 'does this actually work at all?' metric. Signed-off-by: Daniel Stone <[EMAIL PROTECTED]> ---