Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module

2010-09-27 Thread Keerthy
, KEERTHY Cc: linux-omap@vger.kernel.org; lm-sens...@lm-sensors.org; Krishnamoorthy, Balaji T Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module [...] +EXPORT_SYMBOL(twl4030_madc_conversion); + If this function is going to be called from

RE: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module

2010-09-20 Thread J, KEERTHY
-Original Message- From: Guenter Roeck [mailto:guenter.ro...@ericsson.com] Sent: Thursday, September 16, 2010 8:48 PM To: J, KEERTHY Cc: linux-omap@vger.kernel.org; lm-sens...@lm-sensors.org; Krishnamoorthy, Balaji T Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver

Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module

2010-09-20 Thread Guenter Roeck
, Balaji T Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module [...] +EXPORT_SYMBOL(twl4030_madc_conversion); + If this function is going to be called from external code, it should not really be defined here. I would suggest to move it to a global

Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module

2010-09-20 Thread Guenter Roeck
: linux-omap@vger.kernel.org; lm-sens...@lm-sensors.org; Krishnamoorthy, Balaji T Subject: Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module [...] +EXPORT_SYMBOL(twl4030_madc_conversion); + If this function is going to be called from external code

[PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module

2010-09-16 Thread Keerthy
MADC driver is added under hwmon drivers. This driver monitors the real time conversion of analog signals like battery temperature, battery type, battery level etc. User can also ask for the conversion on a particular channel using the sysfs nodes. Several people have contributed to this driver

Re: [lm-sensors] [PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module

2010-09-16 Thread Guenter Roeck
On Thu, Sep 16, 2010 at 06:23:24AM -0400, Keerthy wrote: MADC driver is added under hwmon drivers. This driver monitors the real time conversion of analog signals like battery temperature, battery type, battery level etc. User can also ask for the conversion on a particular channel using the

[PATCH 1/2] hwmon: twl4030: Driver for twl4030 madc module

2010-09-15 Thread Keerthy
MADC driver is added under hwmon drivers. This driver monitors the real time conversion of analog signals like battery temperature, battery type, battery level etc. User can also ask for the conversion on a particular channel using the sysfs nodes. Several people have contributed to this driver