Re: [PATCH 1/2] hwspinlock/omap: enable module before reading SYSSTATUS register

2014-07-27 Thread Ohad Ben-Cohen
On Thu, Jul 24, 2014 at 6:13 PM, Suman Anna s-a...@ti.com wrote: Is there a specific reason for using the put_sync variant here? If not, let's just use the regular put(). There was no particular reason, you can change it. Thanks for confirming. I've applied both patches to remoteproc's

Re: [PATCH 1/2] hwspinlock/omap: enable module before reading SYSSTATUS register

2014-07-24 Thread Ohad Ben-Cohen
Hi Suman, On Thu, Jul 3, 2014 at 2:00 AM, Suman Anna s-a...@ti.com wrote: The number of hwspinlocks are determined based on the value read from the IP block's SYSSTATUS register. However, the module may not be enabled and clocked, and the read may result in a bus error. This particular issue

Re: [PATCH 1/2] hwspinlock/omap: enable module before reading SYSSTATUS register

2014-07-24 Thread Suman Anna
Hi Ohad, On 07/24/2014 08:45 AM, Ohad Ben-Cohen wrote: Hi Suman, On Thu, Jul 3, 2014 at 2:00 AM, Suman Anna s-a...@ti.com wrote: The number of hwspinlocks are determined based on the value read from the IP block's SYSSTATUS register. However, the module may not be enabled and clocked, and

[PATCH 1/2] hwspinlock/omap: enable module before reading SYSSTATUS register

2014-07-02 Thread Suman Anna
The number of hwspinlocks are determined based on the value read from the IP block's SYSSTATUS register. However, the module may not be enabled and clocked, and the read may result in a bus error. This particular issue is seen rather easily on AM33XX, since the module wakeup is software