Re: [PATCH 1/2] musb: musb: dsps: support multiple instances

2013-06-19 Thread Sebastian Andrzej Siewior
On 06/18/2013 10:27 AM, Felipe Balbi wrote: --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -341,6 +341,14 @@ port1-mode = 3; power = 250; ti,hwmods = usb_otg_hs; + phys = nopphy0 nopphy1; + }; + + nopphy0: usbphy@0 { +

Re: [PATCH 1/2] musb: musb: dsps: support multiple instances

2013-06-18 Thread Felipe Balbi
On Mon, Jun 17, 2013 at 05:13:33PM +0200, Sebastian Andrzej Siewior wrote: If we specify right now more than once instance then we attempt to add the platform device twice. The nop driver does not mind the second add because it checks for it and returns without a word. At removal time a

Re: [PATCH 1/2] musb: musb: dsps: support multiple instances

2013-06-18 Thread Sebastian Andrzej Siewior
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/18/2013 10:27 AM, Felipe Balbi wrote: diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index e1b661d..d9ff390 100644 --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -415,9 +415,14 @@ static

Re: [PATCH 1/2] musb: musb: dsps: support multiple instances

2013-06-18 Thread Felipe Balbi
Hi, On Tue, Jun 18, 2013 at 10:34:41AM +0200, Sebastian Andrzej Siewior wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/18/2013 10:27 AM, Felipe Balbi wrote: diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index e1b661d..d9ff390 100644 ---

[PATCH 1/2] musb: musb: dsps: support multiple instances

2013-06-17 Thread Sebastian Andrzej Siewior
If we specify right now more than once instance then we attempt to add the platform device twice. The nop driver does not mind the second add because it checks for it and returns without a word. At removal time a segfault is likely because the first intance clean ups the phy and second, well, goes