Re: [PATCH 1/2] staging: iio: tsl2563 ambient light sensor driver

2009-11-10 Thread Amit Kucheria
On 09 Nov 09, Jonathan Cameron wrote: > Amit Kucheria wrote: > > On 09 Nov 09, Jonathan Cameron wrote: > >> Hi Amit, > >> > >> Normally I'd welcome this in IIO, except that all ambient light sensors > >> are in the > >> process of moving to the new ALS subsystem. There are still some issues > >>

Re: [PATCH 1/2] staging: iio: tsl2563 ambient light sensor driver

2009-11-10 Thread Zhang Rui
On Tue, 2009-11-10 at 02:08 +0800, Jonathan Cameron wrote: > Amit Kucheria wrote: > > On 09 Nov 09, Jonathan Cameron wrote: > >> Hi Amit, > >> > >> Normally I'd welcome this in IIO, except that all ambient light sensors > >> are in the > >> process of moving to the new ALS subsystem. There are st

Re: [PATCH 1/2] staging: iio: tsl2563 ambient light sensor driver

2009-11-09 Thread Jonathan Cameron
Hi Amit, As a whole looks pretty good and a lot of the points are more suggestions on how to simplify the code in places. Where we go wrt ALS and this driver is I guess going to be a bit time dependent. I like the auto adjusting code, though would prefer it to be disabled by default (perhaps via

Re: [PATCH 1/2] staging: iio: tsl2563 ambient light sensor driver

2009-11-09 Thread Jonathan Cameron
Amit Kucheria wrote: > On 09 Nov 09, Jonathan Cameron wrote: >> Hi Amit, >> >> Normally I'd welcome this in IIO, except that all ambient light sensors are >> in the >> process of moving to the new ALS subsystem. There are still some issues to >> resolve >> in that subsystem (mainly to do with na

Re: [PATCH 1/2] staging: iio: tsl2563 ambient light sensor driver

2009-11-09 Thread Amit Kucheria
On 09 Nov 09, Jonathan Cameron wrote: > Hi Amit, > > Normally I'd welcome this in IIO, except that all ambient light sensors are > in the > process of moving to the new ALS subsystem. There are still some issues to > resolve > in that subsystem (mainly to do with naming conventions) but hopeful

Re: [PATCH 1/2] staging: iio: tsl2563 ambient light sensor driver

2009-11-09 Thread Jonathan Cameron
> Hi Amit, > > Normally I'd welcome this in IIO, except that all ambient light sensors are > in the > process of moving to the new ALS subsystem. There are still some issues to > resolve > in that subsystem (mainly to do with naming conventions) but hopefully we will > get them sorted out shor

Re: [PATCH 1/2] staging: iio: tsl2563 ambient light sensor driver

2009-11-09 Thread Jonathan Cameron
Hi Amit, Normally I'd welcome this in IIO, except that all ambient light sensors are in the process of moving to the new ALS subsystem. There are still some issues to resolve in that subsystem (mainly to do with naming conventions) but hopefully we will get them sorted out shortly. I'll take a

[PATCH 1/2] staging: iio: tsl2563 ambient light sensor driver

2009-11-09 Thread Amit Kucheria
Add driver support for the tsl2563 TAOS ambient light sensor. After looking at discussions on LKML, the driver was modified from a 'hwmon' driver to an 'iio' driver. The sysfs interfaces have been tested on an RX51 (N900) to see if it responds to changing light conditions. The only real reason for