Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

2008-04-14 Thread Tony Lindgren
* andrzej zaborowski [EMAIL PROTECTED] [080409 18:12]: On 10/04/2008, Daniel Stone [EMAIL PROTECTED] wrote: On Thu, Apr 10, 2008 at 01:58:51AM +0200, ext andrzej zaborowski wrote: On 09/04/2008, Lauri Leukkunen [EMAIL PROTECTED] wrote: In my opinion kernel should provide correct data

Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

2008-04-09 Thread Felipe Balbi
below. From 3bab182ebe0f922773e62bf6915a8bef1222cec0 Mon Sep 17 00:00:00 2001 From: Daniel Stone [EMAIL PROTECTED] Date: Mon, 7 Apr 2008 17:07:37 +0300 Subject: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver Introduce lm8323 keypad driver. Signed-off-by: Daniel Stone [EMAIL PROTECTED

Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

2008-04-09 Thread andrzej zaborowski
+}; + +I2C_CLIENT_INSMOD; This was garbage, already remove in this version below. From 3bab182ebe0f922773e62bf6915a8bef1222cec0 Mon Sep 17 00:00:00 2001 From: Daniel Stone [EMAIL PROTECTED] Date: Mon, 7 Apr 2008 17:07:37 +0300 Subject: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad

Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

2008-04-09 Thread Lauri Leukkunen
On 09/04/08 21:05 +0300, ext Felipe Balbi wrote: On Wed, Apr 09, 2008 at 07:26:31PM +0200, andrzej zaborowski wrote: Question not really related to this patchset, but in the TSC2005 driver some averaging and limit checks are done to the ADC values. Shouldn't that be done in userspace

Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

2008-04-09 Thread Daniel Stone
On Wed, Apr 09, 2008 at 09:05:58PM +0300, ext Felipe Balbi wrote: On Wed, Apr 09, 2008 at 07:26:31PM +0200, andrzej zaborowski wrote: Question not really related to this patchset, but in the TSC2005 driver some averaging and limit checks are done to the ADC values. Shouldn't that be done in

Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

2008-04-09 Thread andrzej zaborowski
Hi, On 09/04/2008, Lauri Leukkunen [EMAIL PROTECTED] wrote: On 09/04/08 21:05 +0300, ext Felipe Balbi wrote: On Wed, Apr 09, 2008 at 07:26:31PM +0200, andrzej zaborowski wrote: Question not really related to this patchset, but in the TSC2005 driver some averaging and limit checks are

Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

2008-04-09 Thread Daniel Stone
On Thu, Apr 10, 2008 at 01:58:51AM +0200, ext andrzej zaborowski wrote: On 09/04/2008, Lauri Leukkunen [EMAIL PROTECTED] wrote: In my opinion kernel should provide correct data to user-space, not some pseudo-random interference from the LCD. I think this is discutible. There's a number

Re: [PATCH 1/5] I2C: LM8323: Introduce lm8323 keypad driver

2008-04-09 Thread andrzej zaborowski
On 10/04/2008, Daniel Stone [EMAIL PROTECTED] wrote: On Thu, Apr 10, 2008 at 01:58:51AM +0200, ext andrzej zaborowski wrote: On 09/04/2008, Lauri Leukkunen [EMAIL PROTECTED] wrote: In my opinion kernel should provide correct data to user-space, not some pseudo-random interference from