Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-10-10 Thread Paul Walmsley
Hello Ming, On Wed, 28 Sep 2011, Ming Lei wrote: > On Fri, Sep 23, 2011 at 7:31 AM, Paul Walmsley wrote: > > > The idea of the main_clk was not intended to be PRCM or OCP or even > > OMAP-specific.  It's just intended to represent a clock that is used to > > drive the register logic inside the

Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-09-28 Thread Ming Lei
Hi Paul, On Fri, Sep 23, 2011 at 7:31 AM, Paul Walmsley wrote: > The idea of the main_clk was not intended to be PRCM or OCP or even > OMAP-specific.  It's just intended to represent a clock that is used to > drive the register logic inside the IP block.  Therefore it must be > enabled before an

Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-09-26 Thread Cousson, Benoit
Hi Paul, On 9/23/2011 1:31 AM, Paul Walmsley wrote: Hi On Thu, 22 Sep 2011, Cousson, Benoit wrote: ADDR_TYPE_RT is mainly use for sysconfig access inside hwmod core today, so why should we use it in this case? Just for consistency, since the flag isn't defined to be SYSCONFIG-specific. Tha

Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-09-23 Thread Paul Walmsley
Hi On Fri, 23 Sep 2011, Munegowda, Keshava wrote: > Paul Walmsley wrote: > > > So I'd suggest one of two approaches: > > > > 1. If the pin muxing can follow the PM runtime status of the UHH IP block, > >   then the pin mux data should be associated with the UHH hwmod. > > No, the mux is applica

Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-09-23 Thread Munegowda, Keshava
> So I'd suggest one of two approaches: > > 1. If the pin muxing can follow the PM runtime status of the UHH IP block, >   then the pin mux data should be associated with the UHH hwmod. No, the mux is applicable only to ehci and ohci , where as sysconfig is applicable to uhh ( usb_host_hs class).

Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-09-22 Thread Paul Walmsley
Hi On Thu, 22 Sep 2011, Paul Walmsley wrote: > On Thu, 22 Sep 2011, Cousson, Benoit wrote: > > > ADDR_TYPE_RT is mainly use for sysconfig access inside hwmod core today, so > > why should we use it in this case? > > Just for consistency, since the flag isn't defined to be > SYSCONFIG-specific.

Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-09-22 Thread Paul Walmsley
Hi Keshava so based on a closer look at how the EHCI/OHCI IP blocks are actually implemented on OMAP, they should not have hwmod entries associated with them. Please take a look at http://marc.info/?l=linux-omap&m=131673433121673&w=2 - Paul -- To unsubscribe from this list: send the line "u

Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-09-22 Thread Paul Walmsley
Hi On Thu, 22 Sep 2011, Cousson, Benoit wrote: > ADDR_TYPE_RT is mainly use for sysconfig access inside hwmod core today, so > why should we use it in this case? Just for consistency, since the flag isn't defined to be SYSCONFIG-specific. That way, if there's another need -- other than SYSCONF

Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-09-22 Thread Cousson, Benoit
Hi Paul, On 9/22/2011 8:14 PM, Paul Walmsley wrote: Hi On Thu, 22 Sep 2011, Keshava Munegowda wrote: Following 4 hwmod structures are added 1. usb_host_hs hwmod of usbhs with uhh base address and functional clock, 2. usb_ehci_hs hwmod with irq and base address, 3. usb_ohci_hs hwmod with irq a

Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-09-22 Thread Paul Walmsley
Hi On Thu, 22 Sep 2011, Keshava Munegowda wrote: > Following 4 hwmod structures are added > 1. usb_host_hs hwmod of usbhs with uhh base address and functional clock, > 2. usb_ehci_hs hwmod with irq and base address, > 3. usb_ohci_hs hwmod with irq and base address, >- The ehci and ohci hwmods

[PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-09-22 Thread Keshava Munegowda
From: Benoit Cousson Following 4 hwmod structures are added 1. usb_host_hs hwmod of usbhs with uhh base address and functional clock, 2. usb_ehci_hs hwmod with irq and base address, 3. usb_ohci_hs hwmod with irq and base address, - The ehci and ohci hwmods does not require functional clock

[PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

2011-09-22 Thread Keshava Munegowda
From: Benoit Cousson Following 4 hwmod structures are added 1. usb_host_hs hwmod of usbhs with uhh base address and functional clock, 2. usb_ehci_hs hwmod with irq and base address, 3. usb_ohci_hs hwmod with irq and base address, - The ehci and ohci hwmods does not require functional clock