Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-12-04 Thread Russell King - ARM Linux
On Thu, Dec 02, 2010 at 06:01:50PM +, Russell King - ARM Linux wrote: On Thu, Dec 02, 2010 at 05:38:24PM +, Russell King - ARM Linux wrote: What if a platform, for what ever reason, wants to have 3 CPUs, numbered 0, 2, 3 ? That's the reason why the code which sets the possible and

Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-12-02 Thread Catalin Marinas
On 1 December 2010 00:25, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Nov 30, 2010 at 11:32:04PM +, Russell King - ARM Linux wrote: Note that I'll go with factoring this out into arch/arm/kernel/smp_scu.c for the time being, but I'm not convinced about the other parts

Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-12-02 Thread Russell King - ARM Linux
On Thu, Dec 02, 2010 at 03:19:05PM +, Catalin Marinas wrote: On 1 December 2010 00:25, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Nov 30, 2010 at 11:32:04PM +, Russell King - ARM Linux wrote: Note that I'll go with factoring this out into arch/arm/kernel/smp_scu.c

Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-12-02 Thread Catalin Marinas
On Thu, 2010-12-02 at 15:24 +, Russell King - ARM Linux wrote: On Thu, Dec 02, 2010 at 03:19:05PM +, Catalin Marinas wrote: On 1 December 2010 00:25, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Nov 30, 2010 at 11:32:04PM +, Russell King - ARM Linux wrote:

Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-12-02 Thread Russell King - ARM Linux
On Thu, Dec 02, 2010 at 04:28:40PM +, Catalin Marinas wrote: The SCU is part of the core TRM, so I don't expect it to be the same across various MP cores (and A15 is an example). You may want to consolidate functions like scu_prepare_cpus (maybe call it smp_prepare_cpus) You do realise

Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-12-02 Thread Catalin Marinas
On Thu, 2010-12-02 at 17:38 +, Russell King - ARM Linux wrote: On Thu, Dec 02, 2010 at 04:28:40PM +, Catalin Marinas wrote: The SCU is part of the core TRM, so I don't expect it to be the same across various MP cores (and A15 is an example). You may want to consolidate functions

Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-12-02 Thread Russell King - ARM Linux
On Thu, Dec 02, 2010 at 05:38:24PM +, Russell King - ARM Linux wrote: What if a platform, for what ever reason, wants to have 3 CPUs, numbered 0, 2, 3 ? That's the reason why the code which sets the possible and present maps isn't in the ARM core code - Eg, we don't know if a platform

[PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-11-30 Thread Anton Vorontsov
For CNS3xxx we want to reuse the original ARM approach of booting secondary CPUs. This patch factors out VExpress' code into a common file, so that now platform code can call these routines. Note that this patch doesn't convert VExpress platform to the generic routines. Plus, there are also a lot

Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-11-30 Thread Russell King - ARM Linux
On Tue, Nov 30, 2010 at 08:16:58PM +0300, Anton Vorontsov wrote: For CNS3xxx we want to reuse the original ARM approach of booting secondary CPUs. This patch factors out VExpress' code into a common file, so that now platform code can call these routines. Note that this patch doesn't convert

Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-11-30 Thread Russell King - ARM Linux
On Tue, Nov 30, 2010 at 08:16:58PM +0300, Anton Vorontsov wrote: +/* + * Initialise the CPU possible map early - this describes the CPUs + * which may be present or become present in the system. + */ +void __init scu_init_cpus(void __iomem *scu_base) +{ + unsigned int ncores = scu_base

Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-11-30 Thread Russell King - ARM Linux
On Tue, Nov 30, 2010 at 11:32:04PM +, Russell King - ARM Linux wrote: Note that I'll go with factoring this out into arch/arm/kernel/smp_scu.c for the time being, but I'm not convinced about the other parts yet. IOW, something like the attached. I've gone a little further and removed the

Re: [PATCH 1/8] ARM: SCU: Add common routines for secondary CPU bootup

2010-11-30 Thread Srinidhi Kasagar
On Wed, Dec 1, 2010 at 5:02 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Nov 30, 2010 at 08:16:58PM +0300, Anton Vorontsov wrote: [...] +     sub     r4, r4, r5 +     add     r6, r6, r4 +#if __LINUX_ARM_ARCH__ = 7 +     dsb +#endif Another question though - probably