Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-25 Thread One Thousand Gnomes
> I had a quick look and I guess that uart_change_pm() is the most likely > candidate for what you are referring to. > I can see how that interfaces to the specific piece of uart hardware, such as > omap-serial.c > But I cannot see how you would plumb that though to the device that was > plugged in

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-25 Thread One Thousand Gnomes
> As soon as this patch > (http://www.spinics.net/lists/arm-kernel/msg325197.html) will be > applied, we don't really need this DTR GPIO any more. For the omap specific case, not for the general case of sorting out power hierarchies. Alan -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-25 Thread Yegor Yefremov
On Fri, Apr 25, 2014 at 11:34 AM, NeilBrown wrote: > On Thu, 24 Apr 2014 15:19:14 +0100 One Thousand Gnomes > wrote: > >> > > But I don't have discrete hardware. I have a bunch of stuff soldered >> > > onto a >> > > board with ad-hoc connections chosen to make the life of the hardware >> > > b

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-25 Thread NeilBrown
On Thu, 24 Apr 2014 15:19:14 +0100 One Thousand Gnomes wrote: > > > But I don't have discrete hardware. I have a bunch of stuff soldered > > > onto a > > > board with ad-hoc connections chosen to make the life of the hardware > > > builder > > > easy rather than chosen to make the life of the

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-24 Thread One Thousand Gnomes
> > But I don't have discrete hardware. I have a bunch of stuff soldered onto a > > board with ad-hoc connections chosen to make the life of the hardware > > builder > > easy rather than chosen to make the life of the software developer easy > > (which I think is the correct choice). > > > > So

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
On Wed, 23 Apr 2014 20:43:34 -0500 Felipe Balbi wrote: > so, Ack for $subject or not ? > Just at the moment I'm finding it hard to care. So Acked-by: NeilBrown Whatever NeilBrown signature.asc Description: PGP signature

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Felipe Balbi
Hi, On Thu, Apr 24, 2014 at 11:41:15AM +1000, NeilBrown wrote: > On Wed, 23 Apr 2014 20:21:00 -0500 Felipe Balbi wrote: > > > I have no problem either way, just that unused code doesn't have to be > > sitting in the tree and I'm not entirely sure this GPIO should be > > handled by omap-serial.c,

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
On Wed, 23 Apr 2014 20:21:00 -0500 Felipe Balbi wrote: > I have no problem either way, just that unused code doesn't have to be > sitting in the tree and I'm not entirely sure this GPIO should be > handled by omap-serial.c, perhaps something more generic inside > serial-core so other UART drivers

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Felipe Balbi
Hi, On Thu, Apr 24, 2014 at 10:13:29AM +1000, NeilBrown wrote: > On Wed, 23 Apr 2014 18:01:21 -0500 Felipe Balbi wrote: > > > Hi, > > > > On Thu, Apr 24, 2014 at 08:43:05AM +1000, NeilBrown wrote: > > > On Wed, 23 Apr 2014 10:35:04 -0500 Nishanth Menon wrote: > > > > > > > On 04/23/2014 09:58

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
On Wed, 23 Apr 2014 18:01:21 -0500 Felipe Balbi wrote: > Hi, > > On Thu, Apr 24, 2014 at 08:43:05AM +1000, NeilBrown wrote: > > On Wed, 23 Apr 2014 10:35:04 -0500 Nishanth Menon wrote: > > > > > On 04/23/2014 09:58 AM, Felipe Balbi wrote: > > > > nobody passes a DTR_gpio to this driver, so > >

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Felipe Balbi
Hi, On Thu, Apr 24, 2014 at 08:43:05AM +1000, NeilBrown wrote: > On Wed, 23 Apr 2014 10:35:04 -0500 Nishanth Menon wrote: > > > On 04/23/2014 09:58 AM, Felipe Balbi wrote: > > > nobody passes a DTR_gpio to this driver, so > > > this code is not necessary. > > > > > > Signed-off-by: Felipe Balbi

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread NeilBrown
On Wed, 23 Apr 2014 10:35:04 -0500 Nishanth Menon wrote: > On 04/23/2014 09:58 AM, Felipe Balbi wrote: > > nobody passes a DTR_gpio to this driver, so > > this code is not necessary. > > > > Signed-off-by: Felipe Balbi > > --- > > Niel, > this seems to revert the functionality introduced in >

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Nishanth Menon
On 04/23/2014 09:58 AM, Felipe Balbi wrote: > nobody passes a DTR_gpio to this driver, so > this code is not necessary. > > Signed-off-by: Felipe Balbi > --- Niel, this seems to revert the functionality introduced in commit 9574f36fb801035f6ab0fbb1b53ce2c12c17d100 (OMAP/serial: Add support for d

Re: [PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Felipe Balbi
+Neil On Wed, Apr 23, 2014 at 09:58:34AM -0500, Felipe Balbi wrote: > nobody passes a DTR_gpio to this driver, so > this code is not necessary. > > Signed-off-by: Felipe Balbi > --- > drivers/tty/serial/omap-serial.c | 39 --- > 1 file changed, 39 deletions(-

[PATCH 10/13] tty: serial: omap: remove some dead code

2014-04-23 Thread Felipe Balbi
nobody passes a DTR_gpio to this driver, so this code is not necessary. Signed-off-by: Felipe Balbi --- drivers/tty/serial/omap-serial.c | 39 --- 1 file changed, 39 deletions(-) diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c