RE: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct

2010-06-22 Thread Varadarajan, Charulatha
; p...@pwsan.com; Nayak, Rajendra; t...@atomide.com; Basak, Partha Subject: Re: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct Varadarajan, Charulatha ch...@ti.com writes: [...] So please, don't do that. BTW, you didn't answer the first

Re: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct

2010-06-22 Thread Kevin Hilman
; a...@linux-foundation.org; linux-omap@vger.kernel.org; p...@pwsan.com; Nayak, Rajendra; t...@atomide.com; Basak, Partha Subject: Re: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct Varadarajan, Charulatha ch...@ti.com writes: [...] So please, don't do

Re: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct

2010-06-17 Thread Kevin Hilman
Varadarajan, Charulatha ch...@ti.com writes: [...] So please, don't do that. BTW, you didn't answer the first answer, do you really need that? It is used in save/restore context which would be called from sram_idle path. Cleaning this up should be considered instead of keeping around

RE: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct

2010-06-16 Thread Varadarajan, Charulatha
...@deeprootsystems.com; t...@atomide.com Subject: Re: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct Hi Charu, On 6/15/2010 5:05 PM, Varadarajan, Charulatha wrote: From: Charulatha Vch...@ti.com This patch adds gpio_dev_attr to OMAP4 gpio hwmod structure

Re: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct

2010-06-16 Thread Cousson, Benoit
On 6/16/2010 8:54 AM, Varadarajan, Charulatha wrote: From: Cousson, Benoit Sent: Tuesday, June 15, 2010 10:10 PM Hi Charu, On 6/15/2010 5:05 PM, Varadarajan, Charulatha wrote: From: Charulatha Vch...@ti.com This patch adds gpio_dev_attr to OMAP4 gpio hwmod structure. This patch also

RE: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct

2010-06-16 Thread Varadarajan, Charulatha
On 6/16/2010 8:54 AM, Varadarajan, Charulatha wrote: From: Cousson, Benoit Sent: Tuesday, June 15, 2010 10:10 PM Hi Charu, On 6/15/2010 5:05 PM, Varadarajan, Charulatha wrote: From: Charulatha Vch...@ti.com This patch adds gpio_dev_attr to OMAP4 gpio hwmod structure. This

Re: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct

2010-06-16 Thread Benoit Cousson
On 6/16/2010 5:41 PM, Varadarajan, Charulatha wrote: On 6/16/2010 8:54 AM, Varadarajan, Charulatha wrote: From: Cousson, Benoit Sent: Tuesday, June 15, 2010 10:10 PM Hi Charu, On 6/15/2010 5:05 PM, Varadarajan, Charulatha wrote: From: Charulatha Vch...@ti.com This patch adds

[PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct

2010-06-15 Thread Varadarajan, Charulatha
From: Charulatha V ch...@ti.com This patch adds gpio_dev_attr to OMAP4 gpio hwmod structure. This patch also corrects the gpio .main_clk and .clk fields in gpio hwmod structures. Signed-off-by: Charulatha V ch...@ti.com --- arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 37

Re: [PATCH 10/13 v3] OMAP: GPIO: Add gpio dev_attr and correct clks in OMAP4 hwmod struct

2010-06-15 Thread Benoit Cousson
Hi Charu, On 6/15/2010 5:05 PM, Varadarajan, Charulatha wrote: From: Charulatha Vch...@ti.com This patch adds gpio_dev_attr to OMAP4 gpio hwmod structure. This patch also corrects the gpio .main_clk and .clk fields in gpio hwmod structures. Signed-off-by: Charulatha Vch...@ti.com ---