[PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-02 Thread Vaibhav Bedia
AM335x supports various low power modes as documented in section 8.1.4.3 of the AM335x TRM which is available @ http://www.ti.com/litv/pdf/spruh73f DeepSleep0 mode offers the lowest power mode with limited wakeup sources without a system reboot and is mapped as the suspend state in the kernel. In

RE: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-02 Thread Bedia, Vaibhav
On Fri, Nov 02, 2012 at 18:02:46, Bedia, Vaibhav wrote: [...] > +int wkup_mbox_msg(struct notifier_block *self, unsigned long len, void *msg) > +{ > + return 0; > +} This should have been static. Will change in the next version. -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-03 Thread Santosh Shilimkar
On Friday 02 November 2012 06:02 PM, Vaibhav Bedia wrote: AM335x supports various low power modes as documented in section 8.1.4.3 of the AM335x TRM which is available @ http://www.ti.com/litv/pdf/spruh73f DeepSleep0 mode offers the lowest power mode with limited wakeup sources without a system

RE: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-04 Thread Bedia, Vaibhav
On Sat, Nov 03, 2012 at 22:27:19, Shilimkar, Santosh wrote: [...] > > > Nice descriptive change log Vaibhav. Thanks :) > [...] > > +#include "soc.h" > > + > In case not checked yet, see if you need > all above headers. > Will double-check, I know it's a long list of includes. > > +void (*am

Re: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-05 Thread Kevin Hilman
+Santosh (to help with EMIF questions/comments) On 11/02/2012 12:32 PM, Vaibhav Bedia wrote: > AM335x supports various low power modes as documented > in section 8.1.4.3 of the AM335x TRM which is available > @ http://www.ti.com/litv/pdf/spruh73f > > DeepSleep0 mode offers the lowest power mode wi

Re: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-05 Thread Santosh Shilimkar
On Monday 05 November 2012 11:10 PM, Kevin Hilman wrote: +Santosh (to help with EMIF questions/comments) On 11/02/2012 12:32 PM, Vaibhav Bedia wrote: AM335x supports various low power modes as documented in section 8.1.4.3 of the AM335x TRM which is available @ http://www.ti.com/litv/pdf/spruh7

RE: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-06 Thread Bedia, Vaibhav
Hi Kevin, On Mon, Nov 05, 2012 at 23:10:27, Kevin Hilman wrote: [...] > > First, some general comments. This is a big patch and probably should > be broken up a bit. I suspect it could be broken up a bit, maybe into > at least: > > - EMIF interface > - SCM interface, new APIs > - assembly/OCM

RE: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-06 Thread Bedia, Vaibhav
Hi Santosh, Kevin On Tue, Nov 06, 2012 at 03:22:16, Shilimkar, Santosh wrote: [...] > >> + > >> +/* > >> + * This a subset of registers defined in drivers/memory/emif.h > >> + * Move that to include/linux/? > >> + */ > > > > I'd probably suggest just moving the register definitions you > > need i

Re: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-06 Thread Santosh Shilimkar
On Tuesday 06 November 2012 06:29 AM, Bedia, Vaibhav wrote: Hi Santosh, Kevin On Tue, Nov 06, 2012 at 03:22:16, Shilimkar, Santosh wrote: [...] + +/* + * This a subset of registers defined in drivers/memory/emif.h + * Move that to include/linux/? + */ I'd probably suggest just moving the reg

RE: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-06 Thread Bedia, Vaibhav
On Tue, Nov 06, 2012 at 18:08:36, Shilimkar, Santosh wrote: > On Tuesday 06 November 2012 06:29 AM, Bedia, Vaibhav wrote: > > Hi Santosh, Kevin > > > > On Tue, Nov 06, 2012 at 03:22:16, Shilimkar, Santosh wrote: > > [...] > > > + > +/* > + * This a subset of registers defined in driv

Re: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-06 Thread Kevin Hilman
"Bedia, Vaibhav" writes: > On Mon, Nov 05, 2012 at 23:10:27, Kevin Hilman wrote: [...] >> >> Also, if there are drivers for these devices, won't this interfere? >> > > Hmm, I can think of the following scenarios > > 1. Runtime PM adapted drivers are compiled in - We'll have to ensure that > i

RE: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-07 Thread Bedia, Vaibhav
Hi Kevin, On Wed, Nov 07, 2012 at 06:36:06, Kevin Hilman wrote: > "Bedia, Vaibhav" writes: > > > On Mon, Nov 05, 2012 at 23:10:27, Kevin Hilman wrote: > > [...] > > >> > >> Also, if there are drivers for these devices, won't this interfere? > >> > > > > Hmm, I can think of the following scen

Re: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-07 Thread Kevin Hilman
"Bedia, Vaibhav" writes: > Hi Kevin, > > On Wed, Nov 07, 2012 at 06:36:06, Kevin Hilman wrote: >> "Bedia, Vaibhav" writes: >> >> > On Mon, Nov 05, 2012 at 23:10:27, Kevin Hilman wrote: >> >> [...] >> >> >> >> >> Also, if there are drivers for these devices, won't this interfere? >> >> >> >

RE: [PATCH 15/15] ARM: OMAP2+: AM33XX: Basic suspend resume support

2012-11-08 Thread Bedia, Vaibhav
On Wed, Nov 07, 2012 at 22:45:20, Kevin Hilman wrote: [...] > >> > > > > We could perhaps add a couple of APIs to check the SYSC values when coming > > out of suspend and take appropriate action if the sysc cache does not match? > > Yes, for IPs with only SW support and no drivers, we may need so