Re: [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method

2011-10-10 Thread Felipe Balbi
On Sun, Oct 02, 2011 at 04:45:45PM +0200, Arnd Bergmann wrote: The logic to allow only one DMA driver in MUSB is currently flawed, because it also allows picking no DMA driver at all and also not selecting PIO mode. Using a choice statement makes this foolproof for now and also simplifies

Re: [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method

2011-10-03 Thread Arnd Bergmann
On Monday 03 October 2011 01:10:51 Felipe Balbi wrote: Anyway, I'll take your patches in, but their too late for this merge window I already sent my last pull to Greg. No problem. I need the full set of arm-randconfig patches upstream in order to make randconfig work in general, and that's not

Re: [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method

2011-10-03 Thread Felipe Balbi
Hi, On Mon, Oct 03, 2011 at 11:40:26AM +0200, Arnd Bergmann wrote: On Monday 03 October 2011 01:10:51 Felipe Balbi wrote: Anyway, I'll take your patches in, but their too late for this merge window I already sent my last pull to Greg. No problem. I need the full set of arm-randconfig

[PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method

2011-10-02 Thread Arnd Bergmann
The logic to allow only one DMA driver in MUSB is currently flawed, because it also allows picking no DMA driver at all and also not selecting PIO mode. Using a choice statement makes this foolproof for now and also simplifies the Makefile. Unfortunately, we will have to revisit this when we

Re: [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method

2011-10-02 Thread Russell King - ARM Linux
On Sun, Oct 02, 2011 at 04:45:45PM +0200, Arnd Bergmann wrote: The logic to allow only one DMA driver in MUSB is currently flawed, because it also allows picking no DMA driver at all and also not selecting PIO mode. Using a choice statement makes this foolproof for now and also simplifies

Re: [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method

2011-10-02 Thread Arnd Bergmann
On Sunday 02 October 2011 17:14:47 Russell King - ARM Linux wrote: On Sun, Oct 02, 2011 at 04:45:45PM +0200, Arnd Bergmann wrote: The logic to allow only one DMA driver in MUSB is currently flawed, because it also allows picking no DMA driver at all and also not selecting PIO mode.

Re: [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method

2011-10-02 Thread Felipe Balbi
Hi, On Sun, Oct 02, 2011 at 08:00:31PM +0200, Arnd Bergmann wrote: On Sunday 02 October 2011 17:14:47 Russell King - ARM Linux wrote: On Sun, Oct 02, 2011 at 04:45:45PM +0200, Arnd Bergmann wrote: The logic to allow only one DMA driver in MUSB is currently flawed, because it also allows

Re: [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method

2011-10-02 Thread Arnd Bergmann
On Sunday 02 October 2011 21:56:09 Felipe Balbi wrote: Unfortunately, even with the dma parts out of the way there is a lot that needs to be done to make musb, ehci or ohci really cross-platform. Right now, you can only have one platform driver glue for each of those drivers, and they

Re: [PATCH 15/30] usb/musb: use a Kconfig choice to pick the right DMA method

2011-10-02 Thread Felipe Balbi
Hi, On Sun, Oct 02, 2011 at 09:44:26PM +0200, Arnd Bergmann wrote: that's how MUSB works now and that's what I have been discussing with Alan Stern for the past month or so, wrt to *HCI. There are even patches floating on linux-usb right now trying to hash out the problems. Ah, glad to