Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-13 Thread Vimal Singh
> Any news on posting the updated version of this? Would be nice to > get it in this merge window, so time's running out :) > > When re-posting, please also cc linux-arm-ker...@lists.infradead.org > in addition to linux-omap list. That way we can have it quickly > reviewed there too. > Sorry for r

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-08 Thread Tony Lindgren
* Tony Lindgren [091207 09:56]: > * Vimal Singh [091207 05:28]: > > On Mon, Dec 7, 2009 at 11:59 AM, Vimal Singh > > wrote: > > > On Sat, Dec 5, 2009 at 3:31 AM, Tony Lindgren wrote: > > >> Hi, > > >> > > >> Looks good, just one comment below. > > >> > > >> * Govindraj.R [091204 05:37]: > > >

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-07 Thread Tony Lindgren
* Vimal Singh [091207 05:28]: > On Mon, Dec 7, 2009 at 11:59 AM, Vimal Singh wrote: > > On Sat, Dec 5, 2009 at 3:31 AM, Tony Lindgren wrote: > >> Hi, > >> > >> Looks good, just one comment below. > >> > >> * Govindraj.R [091204 05:37]: > >>> From: Vimal Singh > >>> Date: Wed, 25 Nov 2009 18:23

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-07 Thread Vimal Singh
On Mon, Dec 7, 2009 at 11:59 AM, Vimal Singh wrote: > On Sat, Dec 5, 2009 at 3:31 AM, Tony Lindgren wrote: >> Hi, >> >> Looks good, just one comment below. >> >> * Govindraj.R [091204 05:37]: >>> From: Vimal Singh >>> Date: Wed, 25 Nov 2009 18:23:15 +0530 >>> Subject: [PATCH] Introducing 'gpmc-

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-06 Thread Vimal Singh
On Sat, Dec 5, 2009 at 3:31 AM, Tony Lindgren wrote: > Hi, > > Looks good, just one comment below. > > * Govindraj.R [091204 05:37]: >> From: Vimal Singh >> Date: Wed, 25 Nov 2009 18:23:15 +0530 >> Subject: [PATCH] Introducing 'gpmc-nand.c' for GPMC specific NAND init >> >> Introducing 'gpmc-nan

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-04 Thread Tony Lindgren
Hi, Looks good, just one comment below. * Govindraj.R [091204 05:37]: > From: Vimal Singh > Date: Wed, 25 Nov 2009 18:23:15 +0530 > Subject: [PATCH] Introducing 'gpmc-nand.c' for GPMC specific NAND init > > Introducing 'gpmc-nand.c' for GPMC specific NAND init. > For example: GPMC timing param

[PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-04 Thread Govindraj.R
From: Vimal Singh Date: Wed, 25 Nov 2009 18:23:15 +0530 Subject: [PATCH] Introducing 'gpmc-nand.c' for GPMC specific NAND init Introducing 'gpmc-nand.c' for GPMC specific NAND init. For example: GPMC timing parameters and all. This patch also migrates gpmc related calls from 'nand/omap2.c' to 'gp

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-04 Thread Govindraj
This patch got line wrapped. -- --- Regards, Govindraj.R On Fri, Dec 4, 2009 at 6:44 PM, Vimal Singh wrote: > Ahh.. this is my bad. > > [...] >> +       err = gpmc_nand_setup((void __iomem *) >> +                                       &gpmc_nand_data->gpmc_cs_baseaddr); > we just do not need c

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-04 Thread Vimal Singh
Ahh.. this is my bad. [...] > +       err = gpmc_nand_setup((void __iomem *) > +                                       &gpmc_nand_data->gpmc_cs_baseaddr); we just do not need casting here. Apologies for making noise and confusion. Please take this one. -vimal >From e024a2e6aa2051259ad904daff13b

Re: [PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-04 Thread Vimal Singh
Hi all, Please ignore previous patch, it has a compilation error. Correct patch is present below. -vimal >From e024a2e6aa2051259ad904daff13bdac73b3b1b8 Mon Sep 17 00:00:00 2001 From: Vimal Singh Date: Wed, 25 Nov 2009 18:23:15 +0530 Subject: [PATCH] Introducing 'gpmc-nand.c' for GPMC specific N

[PATCH 2/2]: Introducing 'gpmc-nand.c' for GPMC specific NAND init

2009-12-03 Thread Vimal Singh
>From fadc45cca4026d26d00a759efdc681303b0d3097 Mon Sep 17 00:00:00 2001 From: Vimal Singh Date: Wed, 25 Nov 2009 18:23:15 +0530 Subject: [PATCH] Introducing 'gpmc-nand.c' for GPMC specific NAND init Introducing 'gpmc-nand.c' for GPMC specific NAND init. For example: GPMC timing parameters and all