[PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-04 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows a clean separation of the driver code and the platform code, as required by the move of the platform header files to

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-03 Thread Jean Pihet
Hi Kevin, On Wed, Oct 3, 2012 at 12:21 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Hi Jean, Jean Pihet jean.pi...@newoldbits.com writes: Remove the device dependent settings (cpu_is_xxx(), IP fck etc.) from the driver code and pass them instead via the platform data. This allows a

[PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-03 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows a clean separation of the driver code and the platform code, as required by the move of the platform header files to

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-03 Thread Kevin Hilman
jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows a clean separation of the driver code and the platform code, as required by the

[PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-03 Thread jean . pihet
From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This allows a clean separation of the driver code and the platform code, as required by the move of the platform header files to

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-03 Thread Jean Pihet
Kevin, On Wed, Oct 3, 2012 at 4:29 PM, Kevin Hilman khil...@deeprootsystems.com wrote: jean.pi...@newoldbits.com writes: From: Jean Pihet j-pi...@ti.com Remove the device dependent code (ex. cpu_is_xxx()) and settings from the driver code and instead pass them via the platform data. This

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-10-02 Thread Kevin Hilman
Hi Jean, Jean Pihet jean.pi...@newoldbits.com writes: Remove the device dependent settings (cpu_is_xxx(), IP fck etc.) from the driver code and pass them instead via the platform data. This allows a clean separation of the driver code and the platform code, as required by the move of the

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-24 Thread Jean Pihet
Hi Tony, On Fri, Sep 21, 2012 at 9:07 PM, Tony Lindgren t...@atomide.com wrote: * Jean Pihet jean.pi...@newoldbits.com [120920 23:31]: On Fri, Sep 21, 2012 at 12:15 AM, Tony Lindgren t...@atomide.com wrote: You should be able to make this even simpler and not have to pass the clock name

[PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-24 Thread Jean Pihet
Remove the device dependent settings (cpu_is_xxx(), IP fck etc.) from the driver code and pass them instead via the platform data. This allows a clean separation of the driver code and the platform code, as required by the move of the platform header files to include/linux/platform_data.

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-21 Thread Jean Pihet
Hi Tony, On Fri, Sep 21, 2012 at 12:15 AM, Tony Lindgren t...@atomide.com wrote: Hi, * Jean Pihet jean.pi...@newoldbits.com [120920 07:48]: --- a/drivers/power/avs/smartreflex.c +++ b/drivers/power/avs/smartreflex.c @@ -131,14 +131,11 @@ static void sr_set_clk_length(struct omap_sr *sr)

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-21 Thread Tony Lindgren
* Jean Pihet jean.pi...@newoldbits.com [120920 23:31]: On Fri, Sep 21, 2012 at 12:15 AM, Tony Lindgren t...@atomide.com wrote: You should be able to make this even simpler and not have to pass the clock name around at all. Just do: syc_ck = clk_get(NULL, fck); ... The problem is that

[PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-20 Thread Jean Pihet
Remove the device dependent settings (cpu_is_xxx(), IP fck etc.) from the driver code and pass them instead via the platform data. This allows a clean separation of the driver code and the platform code. Signed-off-by: Jean Pihet j-pi...@ti.com --- arch/arm/mach-omap2/sr_device.c | 14

Re: [PATCH 2/2] ARM: OMAP: SmartReflex: pass device dependent data via platform data

2012-09-20 Thread Tony Lindgren
Hi, * Jean Pihet jean.pi...@newoldbits.com [120920 07:48]: --- a/drivers/power/avs/smartreflex.c +++ b/drivers/power/avs/smartreflex.c @@ -131,14 +131,11 @@ static void sr_set_clk_length(struct omap_sr *sr) struct clk *sys_ck; u32 sys_clk_speed; - if (cpu_is_omap34xx())