[PATCH 2/2] OMAP: PM: implement devices constraints APIs

2011-03-09 Thread Jean Pihet
Implement OMAP PM layer omap_pm_set_max_dev_wakeup_lat API by creating a unified API which calls omap_device_set_dev_constraint for all classes of constraints (devices wake-up latency, devices throughput...). The implementation of the constraints framework is at the omap_device level: management an

Re: [PATCH 2/2] OMAP: PM: implement devices constraints APIs

2011-03-09 Thread Jean Pihet
Hi, This patch is sent as en early review request, the testing is still on-going. I will post the updated series (with a new revision number) as soon as possible. I have some inlined comments, questions and concerns about it. Can you please check? On Wed, Mar 9, 2011 at 8:19 PM, Jean Pihet wrot

Re: [PATCH 2/2] OMAP: PM: implement devices constraints APIs

2011-03-09 Thread Paul Walmsley
Hello Jean Thanks for working on this stuff. Some comments based on a quick look... On Wed, 9 Mar 2011, Jean Pihet wrote: > Implement OMAP PM layer omap_pm_set_max_dev_wakeup_lat API by > creating a unified API which calls omap_device_set_dev_constraint > for all classes of constraints (devices

Re: [PATCH 2/2] OMAP: PM: implement devices constraints APIs

2011-03-10 Thread Jean Pihet
Hi Paul, On Thu, Mar 10, 2011 at 5:03 AM, Paul Walmsley wrote: > Hello Jean > > Thanks for working on this stuff.  Some comments based on a quick look... > > On Wed, 9 Mar 2011, Jean Pihet wrote: > >> Implement OMAP PM layer omap_pm_set_max_dev_wakeup_lat API by >> creating a unified API which ca

Re: [PATCH 2/2] OMAP: PM: implement devices constraints APIs

2011-03-10 Thread Kevin Hilman
Jean Pihet writes: [...] >> Please create two different functions, >> omap_device_set_max_dev_wakeup_lat() and >> omap_device_set_min_bus_tput().  Documentation/CodingStyle chapter 6. >> > It has been agreed (in weekly calls) to have two functions at the OMAP > PM level but only one function wit

Re: [PATCH 2/2] OMAP: PM: implement devices constraints APIs

2011-03-10 Thread Kevin Hilman
Jean Pihet writes: [...] >> +       if (pwrdm_read_pwrst(pwrdm) != new_state) { >> +               ret = omap_set_pwrdm_state(pwrdm, new_state); > > The function pwrdms_setup (called from omap3_pm_init for every pwrdm) > runs late in the boot process and so it overwrites the registers > values p