Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-08-20 Thread Omar Ramirez Luna
Hi Benoit, On 20 August 2012 05:21, Benoit Cousson wrote: > Hi Omar, > > On 08/03/2012 05:52 PM, Omar Ramirez Luna wrote: >> On 3 August 2012 00:24, Vaibhav Hiremath wrote: >>> On 8/3/2012 3:50 AM, Omar Ramirez Luna wrote: So in _enable: _enable_clocks(oh); if

Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-08-20 Thread Benoit Cousson
Hi Omar, On 08/03/2012 05:52 PM, Omar Ramirez Luna wrote: > On 3 August 2012 00:24, Vaibhav Hiremath wrote: >> On 8/3/2012 3:50 AM, Omar Ramirez Luna wrote: >>> So in _enable: >>> >>> _enable_clocks(oh); >>> if (soc_ops.enable_module) >>> soc_ops.enable_module(oh);

Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-08-03 Thread Omar Ramirez Luna
On 3 August 2012 00:24, Vaibhav Hiremath wrote: > On 8/3/2012 3:50 AM, Omar Ramirez Luna wrote: >> So in _enable: >> >> _enable_clocks(oh); >> if (soc_ops.enable_module) >> soc_ops.enable_module(oh); >> >> The enable_module part seems redundant to me, since the modu

Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-08-02 Thread Vaibhav Hiremath
On 8/3/2012 3:50 AM, Omar Ramirez Luna wrote: > Hi. > > On 2 August 2012 02:52, Paul Walmsley wrote: >> On Mon, 16 Jul 2012, Omar Ramirez Luna wrote: >> >>> For a reset sequence to complete cleanly, a module needs its >>> associated clocks to be enabled, otherwise the timeout check >>> in prcm

Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-08-02 Thread Omar Ramirez Luna
Hi. On 2 August 2012 02:52, Paul Walmsley wrote: > On Mon, 16 Jul 2012, Omar Ramirez Luna wrote: > >> For a reset sequence to complete cleanly, a module needs its >> associated clocks to be enabled, otherwise the timeout check >> in prcm code can print a false failure (failed to hardreset) >> tha

Re: [PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-08-02 Thread Paul Walmsley
Hello OMar, On Mon, 16 Jul 2012, Omar Ramirez Luna wrote: > For a reset sequence to complete cleanly, a module needs its > associated clocks to be enabled, otherwise the timeout check > in prcm code can print a false failure (failed to hardreset) > that occurs because the clocks aren't powered ON

[PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-07-16 Thread Omar Ramirez Luna
For a reset sequence to complete cleanly, a module needs its associated clocks to be enabled, otherwise the timeout check in prcm code can print a false failure (failed to hardreset) that occurs because the clocks aren't powered ON and the status bit checked can't transition without them. Signed-o

[PATCH 2/3] ARM: OMAP: hwmod: revise deassert sequence

2012-06-15 Thread Omar Ramirez Luna
For a reset sequence to complete cleanly, a module needs its associated clocks to be enabled, otherwise the timeout check in prcm code can print a false failure (failed to hardreset) that occurs because the clocks aren't powered ON and the status bit checked can't transition without them. Signed-o