Re: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-03-10 Thread Olof Johansson
On Wed, Mar 10, 2010 at 03:47:08PM +0530, Maulik wrote: > > >Hmm. I must be missing something, but it looks odd to have both the > >USB_MUSB_HDRC and USB_MUSB_SOC high-level config options, especially since > >the depends are duplicated across them. > > >In general, options like these tend to sca

RE: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-03-10 Thread Maulik
>Hmm. I must be missing something, but it looks odd to have both the >USB_MUSB_HDRC and USB_MUSB_SOC high-level config options, especially since >the depends are duplicated across them. >In general, options like these tend to scale badly: >config USB_MUSB_SOC > boolean > depends on

Re: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-03-01 Thread Olof Johansson
On Mon, Mar 01, 2010 at 11:11:29AM +0530, Maulik wrote: > > Olof, > > > > We have such an option "USB_MUSB_SOC" that takes care of all platforms > where > > MUSB is present. But the Inventra DMA case is typical. Not all > architectures > > that have MUSB use Inventra DMA for e.g Davinci uses CPPI

RE: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-02-28 Thread Maulik
> Olof, > > We have such an option "USB_MUSB_SOC" that takes care of all platforms where > MUSB is present. But the Inventra DMA case is typical. Not all architectures > that have MUSB use Inventra DMA for e.g Davinci uses CPPI DMA. >>Yeah, sorry. I didn't mean the INVENTRA_DMA config option as m

Re: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-02-26 Thread Olof Johansson
On Fri, Feb 26, 2010 at 02:10:31PM +0530, Maulik wrote: > >>Adding more and more depends also doesn't scale well. It's time for > >>someone to switch the test around, add a ARCH_HAS_MUSB, select it on > >>the platforms that has it and make the config option depend on that, > >>similar to how (some

RE: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-02-26 Thread Maulik
> > @@ -153,7 +157,7 @@ config MUSB_PIO_ONLY > > config USB_INVENTRA_DMA > > bool > > depends on USB_MUSB_HDRC && !MUSB_PIO_ONLY > > - default ARCH_OMAP2430 || ARCH_OMAP34XX || BLACKFIN > > + default ARCH_OMAP2430 || ARCH_OMAP34XX || BLACKFIN || ARCH_OMAP4 > > help > > Enable

Re: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-02-25 Thread Olof Johansson
On Thu, Feb 25, 2010 at 10:48:34AM -0800, Tony Lindgren wrote: > * Maulik Mankad [100224 22:33]: > > This patch adds the OMAP4 Kconfig options for MUSB. > > > > Signed-off-by: Maulik Mankad > > Cc: Felipe Balbi > > Cc: Greg Kroah-Hartman > > Cc: David Brownell > --- > > Index: mainline/driver

Re: [PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-02-25 Thread Tony Lindgren
* Maulik Mankad [100224 22:33]: > This patch adds the OMAP4 Kconfig options for MUSB. > > Signed-off-by: Maulik Mankad > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: David Brownell --- > Index: mainline/drivers/usb/musb/Kconfig >

[PATCH 2/4] USB: MUSB: Enable MUSB for OMAP4 in Kconfig

2010-02-24 Thread Maulik Mankad
This patch adds the OMAP4 Kconfig options for MUSB. Signed-off-by: Maulik Mankad Cc: Felipe Balbi Cc: Greg Kroah-Hartman Cc: David Brownell http://vger.kernel.org/majordomo-info.html