Re: [PATCH 2/7] omap: mailbox: check for NULL nb in mailbox_put

2013-06-10 Thread Suman Anna
Russ, On 06/08/2013 01:46 PM, Russ Dill wrote: On Fri, Jun 7, 2013 at 6:57 PM, Suman Anna s-a...@ti.com wrote: The mailbox_put function must check the notifier block for NULL before trying to unregister it. I'm going to nack this one. Why must it check for NULL? None of the callers pass a

Re: [PATCH 2/7] omap: mailbox: check for NULL nb in mailbox_put

2013-06-08 Thread Russ Dill
On Fri, Jun 7, 2013 at 6:57 PM, Suman Anna s-a...@ti.com wrote: The mailbox_put function must check the notifier block for NULL before trying to unregister it. I'm going to nack this one. Why must it check for NULL? None of the callers pass a NULL argument and blocking_notifier_chain_unregister

[PATCH 2/7] omap: mailbox: check for NULL nb in mailbox_put

2013-06-07 Thread Suman Anna
The mailbox_put function must check the notifier block for NULL before trying to unregister it. Signed-off-by: Fernando Guzman Lugo lugo.ferna...@gmail.com Signed-off-by: Suman Anna s-a...@ti.com --- arch/arm/plat-omap/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git