Re: [alsa-devel] [PATCH 2/8] ASoC: OMAP: RX-51 Machine driver and AIC34b_dummy driver

2009-10-09 Thread Mark Brown
On Fri, Oct 09, 2009 at 09:37:20AM +0300, Eduardo Valentin wrote: > On Fri, Oct 09, 2009 at 07:44:00AM +0200, Jarkko Nikula wrote: > > Yep, dummy driver is for block B of AIC34 which is basically dual AIC33 > > in a same package. > Yes. This is correct. So to software it just looks like two devi

Re: [PATCH 2/8] ASoC: OMAP: RX-51 Machine driver and AIC34b_dummy driver

2009-10-08 Thread Eduardo Valentin
On Fri, Oct 09, 2009 at 07:44:00AM +0200, Jarkko Nikula wrote: > On Thu, 8 Oct 2009 14:11:16 +0100 > Mark Brown wrote: > > > What is an "AIC34b_dummy (block B)"? You probably want to split it out > > into a separate patch. > > > I think this is the reason why Eduardo mentioned my name in the co

Re: [PATCH 2/8] ASoC: OMAP: RX-51 Machine driver and AIC34b_dummy driver

2009-10-08 Thread Jarkko Nikula
On Thu, 8 Oct 2009 14:11:16 +0100 Mark Brown wrote: > What is an "AIC34b_dummy (block B)"? You probably want to split it out > into a separate patch. > I think this is the reason why Eduardo mentioned my name in the commit log :-) Yep, dummy driver is for block B of AIC34 which is basically du

Re: [PATCH 2/8] ASoC: OMAP: RX-51 Machine driver and AIC34b_dummy driver

2009-10-08 Thread Eduardo Valentin
On Thu, Oct 08, 2009 at 02:31:26PM +0200, Nurkkala Eero.An (EXT-Offcode/Oulu) wrote: > On Thu, 2009-10-08 at 13:58 +0200, Valentin Eduardo (Nokia-D/Helsinki) > wrote: > > From: Eduardo Valentin > > > > Introduce RX-51 Machine driver for ASoC and AIC34b_dummy (block B) i2c > > driver. > > > > Als

Re: [PATCH 2/8] ASoC: OMAP: RX-51 Machine driver and AIC34b_dummy driver

2009-10-08 Thread Mark Brown
On Thu, Oct 08, 2009 at 02:58:51PM +0300, Eduardo Valentin wrote: > From: Eduardo Valentin > Introduce RX-51 Machine driver for ASoC and AIC34b_dummy (block B) i2c driver. What is an "AIC34b_dummy (block B)"? You probably want to split it out into a separate patch. > + * TODO: > + * - Get rid

Re: [PATCH 2/8] ASoC: OMAP: RX-51 Machine driver and AIC34b_dummy driver

2009-10-08 Thread Eero Nurkkala
On Thu, 2009-10-08 at 13:58 +0200, Valentin Eduardo (Nokia-D/Helsinki) wrote: > From: Eduardo Valentin > > Introduce RX-51 Machine driver for ASoC and AIC34b_dummy (block B) i2c driver. > > Also move the request_gpio of speaker_enabled > from board-rx51-peripherals.c to this machine driver. > >

[PATCH 2/8] ASoC: OMAP: RX-51 Machine driver and AIC34b_dummy driver

2009-10-08 Thread Eduardo Valentin
From: Eduardo Valentin Introduce RX-51 Machine driver for ASoC and AIC34b_dummy (block B) i2c driver. Also move the request_gpio of speaker_enabled from board-rx51-peripherals.c to this machine driver. These drivers were originally written by Jarkko Nikula. Signed-off-by: Eduardo Valentin ---