[PATCH 2 14/18] I2C: OMAP1/OMAP2+: create omap I2C functionality flags for each cpu_... test

2011-03-08 Thread Andy Green
These represent the 8 kinds of implementation functionality that up until now were inferred by the 16 remaining cpu_...() tests in the omap i2c driver. Cc: patc...@linaro.org Cc: Ben Dooks Reported-by: Peter Maydell Signed-off-by: Andy Green --- include/linux/i2c-omap.h | 15 +++

Re: [PATCH 2 14/18] I2C: OMAP1/OMAP2+: create omap I2C functionality flags for each cpu_... test

2011-03-09 Thread Krishnamoorthy, Balaji T
On Tue, Mar 8, 2011 at 4:39 PM, Andy Green wrote: > +/* struct omap_i2c_bus_platform_data .flags meanings */ > + > +#define OMAP_I2C_FLAG_NO_FIFO 1 Hi, Minor comment, Can you use BIT(0) for 1, BIT(1) for 2 ... BIT (8) for 0x100 > +#define OMAP_I2C_FLAG_SIMPLE_CLOCK 2 > +#define OMAP_I2C_FLAG_16B

Re: [PATCH 2 14/18] I2C: OMAP1/OMAP2+: create omap I2C functionality flags for each cpu_... test

2011-03-09 Thread Andy Green
On 03/09/2011 02:31 PM, Somebody in the thread at some point said: Hi - Minor comment, Can you use BIT(0) for 1, BIT(1) for 2 ... BIT (8) for 0x100 OK, I agree it will be nicer. Thanks for the comment. I guess I can just change this and issue just this guy as try 3 rather than sending the

Re: [PATCH 2 14/18] I2C: OMAP1/OMAP2+: create omap I2C functionality flags for each cpu_... test

2011-03-09 Thread Cousson, Benoit
On 3/9/2011 4:18 PM, Andy Green wrote: On 03/09/2011 02:31 PM, Somebody in the thread at some point said: Hi - Minor comment, Can you use BIT(0) for 1, BIT(1) for 2 ... BIT (8) for 0x100 OK, I agree it will be nicer. Thanks for the comment. I guess I can just change this and issue just thi