Kevin,
On Thu, Jan 12, 2012 at 1:52 AM, Kevin Hilman wrote:
> Jean Pihet writes:
>
>>> if you already decide in runtime the correct initialization to call, why
>>> do you add ifdefs ?
>>
>> There is no #ifdef with CONFIG_POWER_AVS_OMAP_V[12], those options are
>> used to compile or not the respe
Kevin, Todd,
On Thu, Jan 12, 2012 at 1:55 AM, Kevin Hilman wrote:
> Todd Poynor writes:
>
>>> +static irqreturn_t _interrupt(int irq, void *data)
>>> +{
>>> + struct smartreflex *sr = (struct smartreflex *)data;
>>> + u32 status = 0;
>>> +
>>> + /* Read the status bits */
>>> + sr_re
Todd Poynor writes:
>> +static irqreturn_t _interrupt(int irq, void *data)
>> +{
>> +struct smartreflex *sr = (struct smartreflex *)data;
>> +u32 status = 0;
>> +
>> +/* Read the status bits */
>> +sr_read_reg(sr, IRQSTATUS);
>> +
>> +/* Clear them by writing back */
>> +s
Jean Pihet writes:
>> if you already decide in runtime the correct initialization to call, why
>> do you add ifdefs ?
>
> There is no #ifdef with CONFIG_POWER_AVS_OMAP_V[12], those options are
> used to compile or not the respective modules, cf.
> driver/power/avs/Makefile.
I'd suggest not even
...
> +int sr_configure_errgen(struct smartreflex *sr)
> +{
> + struct smartreflex_platform_data *pdata = sr->pdev->dev.platform_data;
> + u32 sr_config, sr_errconfig;
> +
> + if (IS_ERR_OR_NULL(sr))
> + return -EINVAL;
> +
> + if (!sr_calculate_clk_length(sr))
> +
Hi,
On Wed, Nov 23, 2011 at 12:30:54PM +0100, Jean Pihet wrote:
> >> On Wed, Nov 23, 2011 at 10:51 AM, Felipe Balbi wrote:
> >> > On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com
> >> > wrote:
> >> >> +config POWER_AVS_OMAP_V1
> >> >> + tristate "AVS support for the OMAP I
Felipe,
On Wed, Nov 23, 2011 at 12:04 PM, Felipe Balbi wrote:
> On Wed, Nov 23, 2011 at 11:22:42AM +0100, Jean Pihet wrote:
>> Hi Felipe,
>>
>> On Wed, Nov 23, 2011 at 10:51 AM, Felipe Balbi wrote:
>> > On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com wrote:
>> >> +config POWE
On Wed, Nov 23, 2011 at 11:22:42AM +0100, Jean Pihet wrote:
> Hi Felipe,
>
> On Wed, Nov 23, 2011 at 10:51 AM, Felipe Balbi wrote:
> > On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com wrote:
> >> +config POWER_AVS_OMAP_V1
> >> + tristate "AVS support for the OMAP IP version
Hi Felipe,
On Wed, Nov 23, 2011 at 10:51 AM, Felipe Balbi wrote:
> On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com wrote:
>> +config POWER_AVS_OMAP_V1
>> + tristate "AVS support for the OMAP IP version 1"
>> + depends on ARCH_OMAP3 && PM
>> + help
>> + Say Y
On Tue, Nov 22, 2011 at 04:06:09PM +0100, jean.pi...@newoldbits.com wrote:
> +config POWER_AVS_OMAP_V1
> + tristate "AVS support for the OMAP IP version 1"
> + depends on ARCH_OMAP3 && PM
> + help
> + Say Y to enable AVS support on OMAP containing the version 1 of
> + the Sm
10 matches
Mail list logo
