Re: [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported

2011-12-16 Thread Paul Walmsley
Hi Rajendra, I've combined your patches down to one patch and changed the logic a little bit. It looks to me that the update and clear context registers can be done in one step, since an IP block shouldn't lose context when it's enabled. But maybe I'm missing something? Anyway, I'd

Re: [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported

2011-12-16 Thread Paul Walmsley
Hi On Fri, 16 Dec 2011, Paul Walmsley wrote: + * XXX Will not work correctly if the RM_*_CONTEXT register + * offset is 0 -- probably a flag should be used to avoid this + * situation, rather than testing @oh-prcm.omap4.context_offs. No + * return value. By the way, I'm also worried about

Re: [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported

2011-12-16 Thread Rajendra Nayak
Hi Paul, On Friday 16 December 2011 04:46 PM, Paul Walmsley wrote: Hi Rajendra, I've combined your patches down to one patch and changed the logic a little bit. It looks to me that the update and clear context registers can be done in one step, since an IP block shouldn't lose context when

Re: [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported

2011-12-16 Thread Rajendra Nayak
On Friday 16 December 2011 04:53 PM, Paul Walmsley wrote: Hi On Fri, 16 Dec 2011, Paul Walmsley wrote: + * XXX Will not work correctly if the RM_*_CONTEXT register + * offset is 0 -- probably a flag should be used to avoid this + * situation, rather than testing @oh-prcm.omap4.context_offs.

Re: [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported

2011-12-16 Thread Paul Walmsley
On Fri, 16 Dec 2011, Rajendra Nayak wrote: On Friday 16 December 2011 04:53 PM, Paul Walmsley wrote: On Fri, 16 Dec 2011, Paul Walmsley wrote: + * XXX Will not work correctly if the RM_*_CONTEXT register + * offset is 0 -- probably a flag should be used to avoid this + * situation,

Re: [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported

2011-12-16 Thread Paul Walmsley
On Fri, 16 Dec 2011, Rajendra Nayak wrote: On Friday 16 December 2011 04:46 PM, Paul Walmsley wrote: Hi Rajendra, I've combined your patches down to one patch and changed the logic a little bit. It looks to me that the update and clear context registers can be done in one step,

Re: [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported

2011-12-16 Thread Rajendra Nayak
On Friday 16 December 2011 06:08 PM, Paul Walmsley wrote: On Fri, 16 Dec 2011, Rajendra Nayak wrote: On Friday 16 December 2011 04:46 PM, Paul Walmsley wrote: Hi Rajendra, I've combined your patches down to one patch and changed the logic a little bit. It looks to me that the update and

Re: [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported

2011-12-01 Thread Rajendra Nayak
On Tuesday 29 November 2011 11:40 PM, Cousson, Benoit wrote: Hi Rajendra, Sorry for the delay, I kind of forgot your series :-( On 11/3/2011 11:54 AM, Nayak, Rajendra wrote: Now that OMAP4 has hwmod/module level context lost counters, make omap_hwmod_get_context_loss_count() return them on

Re: [PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported

2011-11-29 Thread Cousson, Benoit
Hi Rajendra, Sorry for the delay, I kind of forgot your series :-( On 11/3/2011 11:54 AM, Nayak, Rajendra wrote: Now that OMAP4 has hwmod/module level context lost counters, make omap_hwmod_get_context_loss_count() return them on platforms where they exist, else fall back on the pwrdm level

[PATCH 3/3] ARM: OMAP: hwmod: Look for hwmod/module level context lost count if supported

2011-11-03 Thread Rajendra Nayak
Now that OMAP4 has hwmod/module level context lost counters, make omap_hwmod_get_context_loss_count() return them on platforms where they exist, else fall back on the pwrdm level counters for older platforms. Signed-off-by: Rajendra Nayak rna...@ti.com --- arch/arm/mach-omap2/omap_hwmod.c | 11