Currently IOVMM driver sets IOVMF_DA_FIXED/IOVMF_DA_ANON flags according
to input 'da' address when mapping memory:
da == 0: IOVMF_DA_ANON
da != 0: IOVMF_DA_FIXED
It prevents IOMMU to map first page with fixed 'da'. To avoid such
issue, IOVMM will not automatically set IOVMF_DA_FIXED. It should
On Tue, Mar 8, 2011 at 6:46 AM, David Cohen daco...@gmail.com wrote:
Currently IOVMM driver sets IOVMF_DA_FIXED/IOVMF_DA_ANON flags according
to input 'da' address when mapping memory:
da == 0: IOVMF_DA_ANON
da != 0: IOVMF_DA_FIXED
It prevents IOMMU to map first page with fixed 'da'. To
From: ext Guzman Lugo, Fernando fernando.l...@ti.com
Subject: Re: [PATCH 3/3] omap: iovmm: don't check 'da' to set
IOVMF_DA_FIXED/IOVMF_DA_ANON flags
Date: Tue, 8 Mar 2011 11:59:43 -0600
On Tue, Mar 8, 2011 at 6:46 AM, David Cohen daco...@gmail.com wrote:
Currently IOVMM driver sets
On Tue, Mar 8, 2011 at 12:09 PM, Hiroshi DOYU hiroshi.d...@nokia.com wrote:
From: ext Guzman Lugo, Fernando fernando.l...@ti.com
Subject: Re: [PATCH 3/3] omap: iovmm: don't check 'da' to set
IOVMF_DA_FIXED/IOVMF_DA_ANON flags
Date: Tue, 8 Mar 2011 11:59:43 -0600
On Tue, Mar 8, 2011 at 6:46
Hi Hiroshi, Fernando,
On Tue, Mar 8, 2011 at 8:53 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Tue, Mar 8, 2011 at 12:09 PM, Hiroshi DOYU hiroshi.d...@nokia.com wrote:
From: ext Guzman Lugo, Fernando fernando.l...@ti.com
Subject: Re: [PATCH 3/3] omap: iovmm: don't check 'da' to set
...@ti.com
Subject: Re: [PATCH 3/3] omap: iovmm: don't check 'da' to set
IOVMF_DA_FIXED/IOVMF_DA_ANON flags
Date: Tue, 8 Mar 2011 11:59:43 -0600
On Tue, Mar 8, 2011 at 6:46 AM, David Cohen daco...@gmail.com wrote:
Currently IOVMM driver sets IOVMF_DA_FIXED/IOVMF_DA_ANON flags according
[snip]
- flags |= (da ? IOVMF_DA_FIXED : IOVMF_DA_ANON);
+ if (~flags IOVMF_DA_FIXED)
+ flags |= IOVMF_DA_ANON;
could we use only one? both are mutual exclusive, what happen if flag
is IOVMF_DA_FIXED | IOVMF_DA_ANON? so, I suggest to get rid of
IOVMF_DA_ANON.
On Tue, Mar 8, 2011 at 9:46 PM, David Cohen daco...@gmail.com wrote:
[snip]
- flags |= (da ? IOVMF_DA_FIXED : IOVMF_DA_ANON);
+ if (~flags IOVMF_DA_FIXED)
+ flags |= IOVMF_DA_ANON;
could we use only one? both are mutual exclusive, what happen if flag
is
