RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-20 Thread Gupta, Ajay Kumar
Hi, > >It would not scale very well - we already have multi-omap builds > >that select support for multiple boards. If the AM35x boards are > >part of such builds, then mutually exclusive config options won't > >work - already n8x0 MUSB is exclusive with 243x/omap3. > > > >If it is possible to dete

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-20 Thread Felipe Balbi
On Thu, May 20, 2010 at 12:06:30PM +0200, Balbi Felipe (Nokia-D/Helsinki) wrote: arm-based only) boards and be sure it would work. We would just need to put something similar down for dma engines. and of course, the same platform-code could instantiate a dma engine platform_device but that's t

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-20 Thread Felipe Balbi
On Thu, May 20, 2010 at 11:41:14AM +0200, ext Gadiyar, Anand wrote: It would not scale very well - we already have multi-omap builds that select support for multiple boards. If the AM35x boards are part of such builds, then mutually exclusive config options won't work - already n8x0 MUSB is exclu

RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-20 Thread Gupta, Ajay Kumar
Hi, > > Fixes/workaround based on CONFIG_MACH_OMAP3517EVM will be good only for > > OMAP3517EVM and would not scale well to other boards based on AM35x. > > (As commented earlier by Sergei) > > > > I just got to know of another board "LIZARD" based on AM35x so we really > > need to find a solution

RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-20 Thread Gupta, Ajay Kumar
Hi, > Gupta, Ajay Kumar wrote: > > >> AM35x supports only 32bit read operations so we need to have > >> workaround for 8bit and 16bit read operations. > > >> Signed-off-by: Ajay Kumar Gupta [...] > >> > >> +#if !defined(CONFIG_MACH_OMAP3517EVM) > > > Fixes/workaround based on CONFIG_MACH_OMAP35

RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-20 Thread Gadiyar, Anand
Gupta, Ajay Kumar wrote: > Fixes/workaround based on CONFIG_MACH_OMAP3517EVM will be good only for > OMAP3517EVM and would not scale well to other boards based on AM35x. > (As commented earlier by Sergei) > > I just got to know of another board "LIZARD" based on AM35x so we really > need to find

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-20 Thread Sergei Shtylyov
Hello. Gupta, Ajay Kumar wrote: AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. Signed-off-by: Ajay Kumar Gupta --- Patch created against linus'tree + all musb patches in Greg's queue Changes from v1: - removed unnecessary

RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-20 Thread Gupta, Ajay Kumar
Hi, > AM35x supports only 32bit read operations so we need to have > workaround for 8bit and 16bit read operations. > > Signed-off-by: Ajay Kumar Gupta > --- > Patch created against linus'tree + all musb patches in Greg's queue > Changes from v1: > - removed unnecessary parens. > - Re

RE: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-18 Thread Gupta, Ajay Kumar
Hi > AM35x supports only 32bit read operations so we need to have > workaround for 8bit and 16bit read operations. > But don't we need to override musb_readb() and musb_readw() then? Yes, Correct. I do have another patch on that which I will cleanup and submit later. Anyways with currebt three

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-18 Thread Sergei Shtylyov
Hello. Ajay Kumar Gupta wrote: AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. But don't we need to override musb_readb() and musb_readw() then? Signed-off-by: Ajay Kumar Gupta WBR, Sergei -- To unsubscribe from this list:

[PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-18 Thread Ajay Kumar Gupta
AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. Signed-off-by: Ajay Kumar Gupta --- Patch created against linus'tree + all musb patches in Greg's queue Changes from v1: - removed unnecessary parens. - Removed 'memcpy' fo

Re: [PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-14 Thread Venkatraman S
Ajay Kumar Gupta wrote: > AM35x supports only 32bit read operations so we need to have > workaround for 8bit and 16bit read operations. > > Signed-off-by: Ajay Kumar Gupta > --- >  drivers/usb/musb/am3517.c    |   30 ++ >  drivers/usb/musb/musb_core.c |    2 ++ >  2 fi

[PATCH 3/3 v2] musb: AM35x: Workaround for fifo read issue

2010-05-14 Thread Ajay Kumar Gupta
AM35x supports only 32bit read operations so we need to have workaround for 8bit and 16bit read operations. Signed-off-by: Ajay Kumar Gupta --- drivers/usb/musb/am3517.c| 30 ++ drivers/usb/musb/musb_core.c |2 ++ 2 files changed, 32 insertions(+), 0 deletio