Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-09 Thread Felipe Balbi
Hi, On Sun, May 08, 2011 at 04:08:37PM +0100, Liam Girdwood wrote: On Wed, 2011-04-27 at 13:45 +0300, Felipe Balbi wrote: Hi, On Wed, Apr 27, 2011 at 10:39:51AM +0100, Graeme Gregory wrote: The twl6025 uses a different regulator for USB than the 6030 so select the correct regulator

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-09 Thread Felipe Balbi
Hi, On Mon, May 09, 2011 at 12:43:49PM +0100, Liam Girdwood wrote: On Mon, 2011-05-09 at 12:03 +0300, Felipe Balbi wrote: Hi, On Sun, May 08, 2011 at 04:08:37PM +0100, Liam Girdwood wrote: On Wed, 2011-04-27 at 13:45 +0300, Felipe Balbi wrote: Hi, On Wed, Apr 27, 2011 at

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-09 Thread Mark Brown
On Mon, May 09, 2011 at 03:16:03PM +0300, Felipe Balbi wrote: On Mon, May 09, 2011 at 12:43:49PM +0100, Liam Girdwood wrote: I think it's the lesser evil though, especially for device integrators. They will just match the regulator name from the schematics together with the TRM name when

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-09 Thread Felipe Balbi
Hi, On Mon, May 09, 2011 at 02:29:41PM +0200, Mark Brown wrote: On Mon, May 09, 2011 at 03:16:03PM +0300, Felipe Balbi wrote: On Mon, May 09, 2011 at 12:43:49PM +0100, Liam Girdwood wrote: I think it's the lesser evil though, especially for device integrators. They will just match the

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-09 Thread Liam Girdwood
On Mon, 2011-05-09 at 15:16 +0300, Felipe Balbi wrote: Hi, On Mon, May 09, 2011 at 12:43:49PM +0100, Liam Girdwood wrote: On Mon, 2011-05-09 at 12:03 +0300, Felipe Balbi wrote: Hi, On Sun, May 08, 2011 at 04:08:37PM +0100, Liam Girdwood wrote: On Wed, 2011-04-27 at 13:45 +0300,

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-09 Thread Mark Brown
On Mon, May 09, 2011 at 04:07:07PM +0300, Felipe Balbi wrote: The thing is. We already had problems in the past with the Clock FW because drivers were passing clock names on platform_data and I really want to avoid the same on regulators. We need something clever. Right, which is why you

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-09 Thread Felipe Balbi
On Mon, May 09, 2011 at 03:35:43PM +0200, Mark Brown wrote: On Mon, May 09, 2011 at 04:07:07PM +0300, Felipe Balbi wrote: The thing is. We already had problems in the past with the Clock FW because drivers were passing clock names on platform_data and I really want to avoid the same on

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-09 Thread Mark Brown
On Mon, May 09, 2011 at 04:51:26PM +0300, Felipe Balbi wrote: On Mon, May 09, 2011 at 03:35:43PM +0200, Mark Brown wrote: - twl-usb3v3 = regulator_get(twl-dev, vusb); + twl-usb3v3 = regulator_get(twl-dev, regulator_name); if (IS_ERR(twl-usb3v3)) return -ENODEV;

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-05-08 Thread Liam Girdwood
On Wed, 2011-04-27 at 13:45 +0300, Felipe Balbi wrote: Hi, On Wed, Apr 27, 2011 at 10:39:51AM +0100, Graeme Gregory wrote: The twl6025 uses a different regulator for USB than the 6030 so select the correct regulator name depending on the subclass of device. Signed-off-by: Graeme

[PATCH 4/4] USB: TWL6025 allow different regulator name

2011-04-27 Thread Graeme Gregory
The twl6025 uses a different regulator for USB than the 6030 so select the correct regulator name depending on the subclass of device. Signed-off-by: Graeme Gregory g...@slimlogic.co.uk --- drivers/usb/otg/twl6030-usb.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff

Re: [PATCH 4/4] USB: TWL6025 allow different regulator name

2011-04-27 Thread Felipe Balbi
Hi, On Wed, Apr 27, 2011 at 10:39:51AM +0100, Graeme Gregory wrote: The twl6025 uses a different regulator for USB than the 6030 so select the correct regulator name depending on the subclass of device. Signed-off-by: Graeme Gregory g...@slimlogic.co.uk I don't see the point of this patch.