[PATCH 4/5] omap: mailbox: fix detection for previously supported chips

2010-10-26 Thread Omar Ramirez Luna
Fix the mailbox detection for OMAP3630 and 2430, also minor cleanup on conditional ifdef's that could affect it. Given that 2430 has an iva too include it, as the same steps for omap3 apply. Signed-off-by: Omar Ramirez Luna --- arch/arm/mach-omap2/mailbox.c | 16 ++-- 1 files chan

RE: [PATCH 4/5] omap: mailbox: fix detection for previously supported chips

2010-10-26 Thread Varadarajan, Charulatha
Kevin Hilman; Ramirez > Luna, Omar; Anna, Suman; Paul Walmsley; Cousson, Benoit; > Raja, Govindraj; C.A, Subramaniam; linux-omap@vger.kernel.org > Subject: [PATCH 4/5] omap: mailbox: fix detection for > previously supported chips > > Fix the mailbox detection for OMAP3630 and 24

Re: [PATCH 4/5] omap: mailbox: fix detection for previously supported chips

2010-10-27 Thread Felipe Contreras
On Wed, Oct 27, 2010 at 8:06 AM, Varadarajan, Charulatha wrote: >> Fix the mailbox detection for OMAP3630 and 2430, also minor >> cleanup on conditional ifdef's that could affect it. >> >> Given that 2430 has an iva too include it, as the same steps >> for omap3 apply. >> >> Signed-off-by: Omar Ra

Re: [PATCH 4/5] omap: mailbox: fix detection for previously supported chips

2010-10-27 Thread Grazvydas Ignotas
On Wed, Oct 27, 2010 at 10:28 AM, Felipe Contreras wrote: > On Wed, Oct 27, 2010 at 8:06 AM, Varadarajan, Charulatha wrote: >> >> Use cpu_is_* check only. No need to have #if CONFIG_ARCH_* checks. > > Some people conditionally compile only for one architecture, like in > consumer devices. There's

Re: [PATCH 4/5] omap: mailbox: fix detection for previously supported chips

2010-10-27 Thread Felipe Contreras
On Wed, Oct 27, 2010 at 12:00 PM, Grazvydas Ignotas wrote: > On Wed, Oct 27, 2010 at 10:28 AM, Felipe Contreras > wrote: >> On Wed, Oct 27, 2010 at 8:06 AM, Varadarajan, Charulatha >> wrote: >>> >>> Use cpu_is_* check only. No need to have #if CONFIG_ARCH_* checks. >> >> Some people conditional