Re: [PATCH 4/7] Hook twl4030 power code into twl4030 core.

2008-10-20 Thread Samuel Ortiz
On Sat, Oct 11, 2008 at 09:50:36PM +0300, Felipe Balbi wrote: > On Fri, Oct 10, 2008 at 07:56:13PM +0300, Peter 'p2' De Schrijver wrote: > > This patch makes twl4030 core call the power code in case the scripts are > > present in the platform data. > > > > Signed-off-by: Peter 'p2' De Schrijver <

Re: [PATCH 4/7] Hook twl4030 power code into twl4030 core.

2008-10-14 Thread David Brownell
On Monday 13 October 2008, Peter 'p2' De Schrijver wrote: > +config TWL4030_POWER > +   bool "Support power sequencing scripts on TWL4030/TPS659x0" > +   depends on TWL4030_CORE=y Don't need "=y" for that, since the CORE is already boolean. > +   help > +     Say yes here if you

[PATCH 4/7] Hook twl4030 power code into twl4030 core.

2008-10-13 Thread Peter 'p2' De Schrijver
This patch makes twl4030 core call the power code in case the scripts are present in the platform data. Signed-off-by: Peter 'p2' De Schrijver <[EMAIL PROTECTED]> --- drivers/mfd/Kconfig|7 +++ drivers/mfd/Makefile |1 + drivers/mfd/twl4030-core.c | 11 +++ 3

Re: [PATCH 4/7] Hook twl4030 power code into twl4030 core.

2008-10-11 Thread Felipe Balbi
On Fri, Oct 10, 2008 at 07:56:13PM +0300, Peter 'p2' De Schrijver wrote: > This patch makes twl4030 core call the power code in case the scripts are > present in the platform data. > > Signed-off-by: Peter 'p2' De Schrijver <[EMAIL PROTECTED]> > --- > drivers/mfd/twl4030-core.c | 11 ++

Re: [PATCH 4/7] Hook twl4030 power code into twl4030 core.

2008-10-10 Thread David Brownell
On Friday 10 October 2008, Peter 'p2' De Schrijver wrote: > +#ifdef CONFIG_TWL4030_POWER Nothing in your patches seems to set that... or update the Makefile so that this file gets linked. Wouldn't it be simpler to just not have that #ifdef, and always link it? If there's no script to install, no

[PATCH 4/7] Hook twl4030 power code into twl4030 core.

2008-10-10 Thread Peter 'p2' De Schrijver
This patch makes twl4030 core call the power code in case the scripts are present in the platform data. Signed-off-by: Peter 'p2' De Schrijver <[EMAIL PROTECTED]> --- drivers/mfd/twl4030-core.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/mfd/twl403