Re: [PATCH 4/9] regulator: twl: Make twl-regulator driver extract data from DT

2011-09-27 Thread Rajendra Nayak
On Tuesday 27 September 2011 05:44 PM, Mark Brown wrote: On Tue, Sep 27, 2011 at 03:42:47PM +0530, Rajendra Nayak wrote: +#ifdef CONFIG_OF + charcompatible[128]; +#endif Might it not be better to just make this a pointer to const char? Yes, my bad. -- To unsubscrib

Re: [PATCH 4/9] regulator: twl: Make twl-regulator driver extract data from DT

2011-09-27 Thread Mark Brown
On Tue, Sep 27, 2011 at 03:42:47PM +0530, Rajendra Nayak wrote: > +#ifdef CONFIG_OF > + charcompatible[128]; > +#endif Might it not be better to just make this a pointer to const char? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of

[PATCH 4/9] regulator: twl: Make twl-regulator driver extract data from DT

2011-09-27 Thread Rajendra Nayak
Modify the twl regulator driver to extract the regulator_init_data from device tree when passed, instead of getting it through platform_data structures (on non-DT builds) Signed-off-by: Rajendra Nayak --- drivers/regulator/twl-regulator.c | 117 - 1 files cha