Re: [PATCH 6/6] omap: move generic omap3 features to generic

2010-05-31 Thread Nishanth Menon
On 06/01/2010 08:34 AM, Venkatraman S wrote: If you can post them formally as part of the series, I can test and ack them (with OMAP3, OMAP4) My original comment was even if these were not implemented due to some constraints, they should be mentioned in the code (as TODO / FIXME etc). The caveat

Re: [PATCH 6/6] omap: move generic omap3 features to generic

2010-05-31 Thread Venkatraman S
On Tue, Jun 1, 2010 at 12:48 AM, Nishanth Menon wrote: > On 05/31/2010 09:46 PM, S, Venkatraman wrote: >> >> I understand that you might not have all platforms to test with, but >> let's not provide a >> 'generic feature api' without it being available for the supported >> platforms. >> It's incom

Re: [PATCH 6/6] omap: move generic omap3 features to generic

2010-05-31 Thread Nishanth Menon
On 05/31/2010 09:46 PM, S, Venkatraman wrote: I understand that you might not have all platforms to test with, but let's not provide a 'generic feature api' without it being available for the supported platforms. It's incomplete without it. well.. if you did read 0/6 http://marc.info/?l=linux-om

Re: [PATCH 6/6] omap: move generic omap3 features to generic

2010-05-31 Thread Venkatraman S
Nishanth Menon wrote: > On 05/31/2010 07:06 PM, Venkatraman S wrote: >> >> Nishanth Menon  wrote: >>> >>> On 05/27/2010 01:24 PM, S, Venkatraman wrote: Nishanth Menon    wrote: >>> >>> [..] > > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c > index 809e13a..

Re: [PATCH 6/6] omap: move generic omap3 features to generic

2010-05-31 Thread Nishanth Menon
On 05/31/2010 07:06 PM, Venkatraman S wrote: Nishanth Menon wrote: On 05/27/2010 01:24 PM, S, Venkatraman wrote: Nishanth Menonwrote: [..] diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c index 809e13a..01555b6 100644 --- a/arch/arm/mach-omap2/id.c +++ b/arch/arm/mach-

Re: [PATCH 6/6] omap: move generic omap3 features to generic

2010-05-31 Thread Venkatraman S
Nishanth Menon wrote: > On 05/27/2010 01:24 PM, S, Venkatraman wrote: >> >> Nishanth Menon  wrote: > > [..] >>> >>> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c >>> index 809e13a..01555b6 100644 >>> --- a/arch/arm/mach-omap2/id.c >>> +++ b/arch/arm/mach-omap2/id.c >>> @@ -161,7

Re: [PATCH 6/6] omap: move generic omap3 features to generic

2010-05-27 Thread Nishanth Menon
On 05/27/2010 01:24 PM, S, Venkatraman wrote: Nishanth Menon wrote: [..] diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c index 809e13a..01555b6 100644 --- a/arch/arm/mach-omap2/id.c +++ b/arch/arm/mach-omap2/id.c @@ -161,7 +161,7 @@ static void __init omap24xx_check_revision(

Re: [PATCH 6/6] omap: move generic omap3 features to generic

2010-05-27 Thread Venkatraman S
Nishanth Menon wrote: > sgx, iva, l2cache, sgx, neon, isp are generic features, make > them generic features, current OMAP3 detection mechanism > is still retained. 192Mhz is more specific OMAP3 feature > so it is retained as is > > Cc: Tony Lindgren > Cc: Angelo Arrifano > Cc: "Zebediah C. McCl

[PATCH 6/6] omap: move generic omap3 features to generic

2010-05-22 Thread Nishanth Menon
sgx, iva, l2cache, sgx, neon, isp are generic features, make them generic features, current OMAP3 detection mechanism is still retained. 192Mhz is more specific OMAP3 feature so it is retained as is Cc: Tony Lindgren Cc: Angelo Arrifano Cc: "Zebediah C. McClure" Cc: Alistair Buxton Cc: Paul Wa